Iterate forward on local serializer mutation batch decoding #2375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (a70acba3) is created by Prow via merging commits: a89e504 2c47eb8. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (a70acba3) is created by Prow via merging commits: a89e504 2c47eb8. |
schmidt-sebastian
approved these changes
Jan 29, 2021
| @@ -202,18 +202,6 @@ public void testTransformAndTransformThrowError() { | |||
| assertThrows(AssertionError.class, () -> serializer.decodeMutationBatch(batchProto)); | |||
| } | |||
|
|
|||
| // TODO(b/174608374): Remove these tests once we perform a schema migration. | |||
| @Test | |||
| public void testOnlyTransformThrowsError() { | |||
There was a problem hiding this comment.
FWIW You could still assert that the first mutation is not a transform. Optional.
There was a problem hiding this comment.
Eh, I'll pass on this one since I don't want to back-back-backport it to iOS again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting from iOS.