Fix startAfter/endBefore for orderByKeys queries #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (c935c70a) is created by Prow via merging commits: 7d2b1a4 79310e6. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (c935c70a) is created by Prow via merging commits: 7d2b1a4 79310e6. |
schmidt-sebastian
approved these changes
Jan 29, 2021
| ? PushIdGenerator.successor(value) | ||
| : value, | ||
| PriorityUtilities.NullPriority()) | ||
| : EmptyNode.Empty(); |
There was a problem hiding this comment.
Can we rewrite this to match the style above? It's a bit hard to parse with two nested conditionals.
There was a problem hiding this comment.
Also - do we not need the validation from https://github.com/firebase/firebase-ios-sdk/pull/7403/files#diff-fa09d2f832ea9e4ec0b8ca482585897a8706c7b6c2a0218250e08ed78c7c3c9aR205 here?
There was a problem hiding this comment.
I commented on that PR, but this case is covered in validateQueryEndpoints:
firebase-database/src/main/java/com/google/firebase/database/Query.java
Outdated
Show resolved
Hide resolved
schmidt-sebastian
approved these changes
Feb 1, 2021
firebase-database/src/main/java/com/google/firebase/database/Query.java
Outdated
Show resolved
Hide resolved
firebase-database/src/main/java/com/google/firebase/database/Query.java
Outdated
Show resolved
Hide resolved
…uery.java Co-authored-by: Sebastian Schmidt <[email protected]>
…uery.java Co-authored-by: Sebastian Schmidt <[email protected]>
firebase-database/src/androidTest/java/com/google/firebase/database/QueryTest.java
Outdated
Show resolved
Hide resolved
firebase-database/src/androidTest/java/com/google/firebase/database/QueryTest.java
Show resolved
Hide resolved
firebase-database/src/main/java/com/google/firebase/database/core/Repo.java
Outdated
Show resolved
Hide resolved
firebase-database/src/main/java/com/google/firebase/database/core/SyncPoint.java
Outdated
Show resolved
Hide resolved
firebase-database/src/main/java/com/google/firebase/database/core/SyncTree.java
Outdated
Show resolved
Hide resolved
firebase-database/src/main/java/com/google/firebase/database/core/SyncTree.java
Outdated
Show resolved
Hide resolved
schmidt-sebastian
approved these changes
Feb 3, 2021
schmidt-sebastian
assigned
wu-hui and
jmwski and unassigned
schmidt-sebastian and
wu-hui
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be passing a fallback key to startAfter if we're querying on a key index. The indexValue is the key in this case.