Skip to content

Add build number to Remote Config #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2021
Merged

Add build number to Remote Config #2380

merged 1 commit into from
Feb 9, 2021

Conversation

andreaowu
Copy link
Contributor

@andreaowu andreaowu commented Jan 29, 2021 •
edited
Loading

Allow users to make conditions using build number like they can for iOS apps

Build version is an internal tracking version of an app, not shown to users (in gradle files, this is versionCode)
App version is the external released version of an app shown to users (in gradle files, this is versionName)

@andreaowu andreaowu requested a review from danasilver January 29, 2021 19:54
@google-cla google-cla bot added the cla: yes Override cla label Jan 29, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-config

    SDK overall coverage changed from 88.58% (7055d2a) to 88.61% (ca185dac) by +0.02%.

    Filename Base (7055d2a) Head (ca185dac) Diff
    ConfigFetchHttpClient.java 85.61% 85.82% +0.21%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (ca185dac) is created by Prow via merging commits: 7055d2a eab3c59.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-config

    Type Base (7055d2a) Head (ca185dac) Diff
    aar 71.5 kB 71.6 kB +123 B (+0.2%)
    apk (aggressive) 91.1 kB 91.2 kB +84 B (+0.1%)
    apk (release) 718 kB 718 kB +148 B (+0.0%)

Test Logs

Notes

Head commit (ca185dac) is created by Prow via merging commits: 7055d2a eab3c59.

danasilver
danasilver reviewed Feb 2, 2021
View reviewed changes
firebase-config/src/main/java/com/google/firebase/remoteconfig/RemoteConfigConstants.java
@@ -59,6 +60,7 @@
String PLATFORM_VERSION = "platformVersion";
String TIME_ZONE = "timeZone";
String APP_VERSION = "appVersion";
String APP_BUILD = "appBuild";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a consistent pattern that the iOS constants use underscores and Android uses camel case

danasilver
danasilver approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@danasilver danasilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - linking the PackageInfoCompat#getLongVersionCode docs since they explain how that number represents versionCode and versionCodeMajor should the latter be used as well.

@andreaowu andreaowu merged commit a48b095 into master Feb 9, 2021
@andreaowu andreaowu deleted the buildapp branch February 9, 2021 19:49
@firebase firebase locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danasilver danasilver danasilver approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreaowu @google-oss-bot @danasilver