Update logging flag to match recommended style and execution. #2392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (d4b0c9ce) is created by Prow via merging commits: 29e73e5 c9b443d. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (d4b0c9ce) is created by Prow via merging commits: 29e73e5 c9b443d. |
|
/test smoke-tests |
vkryachko
reviewed
Feb 2, 2021
firebase-ml-modeldownloader/api.txt
Outdated
| @@ -61,7 +61,7 @@ package com.google.firebase.ml.modeldownloader { | |||
| method @NonNull public com.google.android.gms.tasks.Task<com.google.firebase.ml.modeldownloader.CustomModel> getModel(@NonNull String, @NonNull com.google.firebase.ml.modeldownloader.DownloadType, @Nullable com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions); | |||
| method public long getModelDownloadId(@NonNull String); | |||
| method @NonNull public com.google.android.gms.tasks.Task<java.util.Set<com.google.firebase.ml.modeldownloader.CustomModel>> listDownloadedModels(); | |||
| method public void setStatsCollectionEnabled(boolean); | |||
| method public void setDataCollectionMlDownloaderState(boolean); | |||
There was a problem hiding this comment.
I think the approved naming pattern is set${product}CollectionEnabled(Boolean)
cc @VinayGuthal to confirm
There was a problem hiding this comment.
Looking through - your recommendation is the format used by crashlytics and performance - so updated to match.
There was a problem hiding this comment.
Done - updated method to setModelDownloaderCollectionEnabled(Boolean) and added null edges to reset to default firebase level data collection.
VinayGuthal
requested changes
Feb 3, 2021
...downloader/src/main/java/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.java
Outdated
Show resolved
Hide resolved
VinayGuthal
approved these changes
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.