Skip to content

Fixing BadTokenException while showing FIAM #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 3, 2021

Conversation

eldhosembabu
Copy link
Contributor

Fixing BadTokenException while showing FIAM.

Related Bug : #2107

This is a possible fix as the BadTokenException usually happens when we try to add/show new views with a finishing activity context.

@googlebot googlebot added the cla: yes Override cla label Feb 2, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2021

Coverage Report

Affected SDKs

  • firebase-inappmessaging-display

    SDK overall coverage changed from ? (29e73e5) to 33.49% (be4e6525) by ?.

    Click to show coverage changes in 73 files.
    Filename Base (29e73e5) Head (be4e6525) Diff
    AppComponent.java ? 0.00% ?
    ApplicationModule.java ? 0.00% ?
    ApplicationModule_ProvidesApplicationFactory.java ? 0.00% ?
    BackButtonHandler.java ? 33.33% ?
    BackButtonLayout.java ? 0.00% ?
    BannerBindingWrapper.java ? 92.31% ?
    BannerBindingWrapper_Factory.java ? 0.00% ?
    BaseModalLayout.java ? 10.67% ?
    BindingWrapper.java ? 80.00% ?
    BindingWrapperFactory.java ? 0.00% ?
    BindingWrapperFactory_Factory.java ? 0.00% ?
    CardBindingWrapper.java ? 6.06% ?
    CardBindingWrapper_Factory.java ? 0.00% ?
    CardLayoutLandscape.java ? 0.00% ?
    CardLayoutPortrait.java ? 0.00% ?
    DaggerAppComponent.java ? 0.00% ?
    DaggerInAppMessageComponent.java ? 0.00% ?
    DaggerUniversalComponent.java ? 0.00% ?
    FiamAnimator.java ? 11.63% ?
    FiamAnimator_Factory.java ? 0.00% ?
    FiamCardView.java ? 0.00% ?
    FiamFrameLayout.java ? 28.57% ?
    FiamImageLoader.java ? 86.67% ?
    FiamImageLoader_Factory.java ? 0.00% ?
    FiamListener.java ? 0.00% ?
    FiamRelativeLayout.java ? 28.57% ?
    FiamWindowManager.java ? 71.83% ?
    FiamWindowManager_Factory.java ? 0.00% ?
    FirebaseAppScope.java ? 0.00% ?
    FirebaseInAppMessagingDisplay.java ? 88.55% ?
    FirebaseInAppMessagingDisplayImpl.java ? 43.75% ?
    FirebaseInAppMessagingDisplayRegistrar.java ? 0.00% ?
    FirebaseInAppMessagingDisplay_Factory.java ? 0.00% ?
    HeadlessInAppMessagingModule.java ? 0.00% ?
    HeadlessInAppMessagingModule_ProvidesHeadlesssSingletonFactory.java ? 0.00% ?
    ImageBindingWrapper.java ? 86.96% ?
    ImageBindingWrapper_Factory.java ? 0.00% ?
    InAppMessageComponent.java ? 0.00% ?
    InAppMessageLayoutConfig.java ? 91.84% ?
    InAppMessageScope.java ? 0.00% ?
    InflaterConfigModule.java ? 50.00% ?
    InflaterConfigModule_ProvidesBannerLandscapeLayoutConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesBannerPortraitLayoutConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesCardLandscapeConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesCardPortraitConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesDisplayMetricsFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesLandscapeImageLayoutConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesModalLandscapeConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesModalPortraitConfigFactory.java ? 0.00% ?
    InflaterConfigModule_ProvidesPortraitImageLayoutConfigFactory.java ? 0.00% ?
    InflaterModule.java ? 0.00% ?
    InflaterModule_InAppMessageLayoutConfigFactory.java ? 0.00% ?
    InflaterModule_ProvidesBannerMessageFactory.java ? 0.00% ?
    InflaterModule_ProvidesInflaterserviceFactory.java ? 0.00% ?
    LayoutConfigKey.java ? 0.00% ?
    Logging.java ? 60.00% ?
    MeasureUtils.java ? 0.00% ?
    ModalBindingWrapper.java ? 83.33% ?
    ModalBindingWrapper_Factory.java ? 0.00% ?
    ModalLayoutLandscape.java ? 0.00% ?
    ModalLayoutPortrait.java ? 4.29% ?
    OnSwipeUpListener.java ? 87.50% ?
    PicassoErrorListener.java ? 0.00% ?
    PicassoErrorListener_Factory.java ? 0.00% ?
    PicassoModule.java ? 0.00% ?
    PicassoModule_ProvidesFiamControllerFactory.java ? 0.00% ?
    RenewableTimer.java ? 0.00% ?
    RenewableTimer_Factory.java ? 0.00% ?
    ResizableImageView.java ? 81.25% ?
    SwipeDismissTouchListener.java ? 0.00% ?
    UniversalComponent.java ? 0.00% ?
    VerticalViewGroupMeasure.java ? 7.35% ?
    ViewMeasure.java ? 0.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (be4e6525) is created by Prow via merging commits: 29e73e5 7da66aa.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2021

Binary Size Report

Affected SDKs

  • firebase-inappmessaging-display

    Type Base (29e73e5) Head (be4e6525) Diff
    aar 204 kB 204 kB +75 B (+0.0%)
    apk (aggressive) 1.44 MB 1.44 MB +108 B (+0.0%)
    apk (release) 4.55 MB 4.55 MB +96 B (+0.0%)

Test Logs

Notes

Head commit (be4e6525) is created by Prow via merging commits: 29e73e5 7da66aa.

@eldhosembabu
Copy link
Contributor Author

/test smoke-tests

@eldhosembabu eldhosembabu merged commit 99c41d7 into master Feb 3, 2021
@eldhosembabu eldhosembabu deleted the fiam-fix-bad-window-token branch February 3, 2021 21:25
@firebase firebase locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants