Skip to content

Add DI to FirebasePerfRegistrar.java #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 10, 2021
Merged

Add DI to FirebasePerfRegistrar.java #2406

merged 8 commits into from
Feb 10, 2021

Conversation

visumickey
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Feb 3, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 3, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-perf

    SDK overall coverage changed from 70.22% (6270c03) to 69.84% (4ab891eb) by -0.38%.

    Click to show coverage changes in 12 files.
    Filename Base (6270c03) Head (4ab891eb) Diff
    DaggerFirebasePerformanceComponent.java ? 100.00% ?
    FirebasePerformance.java 83.15% 82.95% -0.19%
    FirebasePerformanceComponent.java ? 0.00% ?
    FirebasePerformanceModule.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesGaugeManagerFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java ? 16.67% ?
    FirebasePerformance_Factory.java ? 8.33% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (4ab891eb) is created by Prow via merging commits: 6270c03 6561dee.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-perf:
error: Added constructor com.google.firebase.perf.FirebasePerformance(com.google.firebase.FirebaseApp,com.google.firebase.inject.Provider<com.google.firebase.remoteconfig.RemoteConfigComponent>,com.google.firebase.installations.FirebaseInstallationsApi,com.google.firebase.inject.Provider<com.google.android.datatransport.TransportFactory>) [AddedMethod]
error: Added class com.google.firebase.perf.FirebasePerformanceComponent [AddedInterface]
error: Added class com.google.firebase.perf.FirebasePerformanceModule [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 3, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-perf

    Type Base (6270c03) Head (4ab891eb) Diff
    aar 292 kB 302 kB +9.99 kB (+3.4%)
    apk (aggressive) 966 kB 966 kB +295 B (+0.0%)
    apk (release) 2.42 MB 2.43 MB +6.52 kB (+0.3%)

Test Logs

Notes

Head commit (4ab891eb) is created by Prow via merging commits: 6270c03 6561dee.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-perf:
error: Added class com.google.firebase.perf.FirebasePerformanceComponent [AddedInterface]
error: Added class com.google.firebase.perf.FirebasePerformanceModule [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

jposuna
jposuna reviewed Feb 4, 2021
View reviewed changes
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-perf:
error: Added class com.google.firebase.perf.FirebasePerformanceComponent [AddedInterface]
error: Added class com.google.firebase.perf.FirebasePerformanceModule [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

blundell
blundell reviewed Feb 4, 2021
View reviewed changes
@jeremyjiang-dev jeremyjiang-dev self-requested a review February 4, 2021 15:31
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-perf:
error: Added class com.google.firebase.perf.FirebasePerformanceComponent [AddedInterface]
error: Added class com.google.firebase.perf.FirebasePerformanceModule [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@jeremyjiang-dev jeremyjiang-dev changed the title Add DI to FirebasePerfResgistrar.java Add DI to FirebasePerfRegistrar.java Feb 5, 2021
@jeremyjiang-dev
Copy link
Contributor

/test check-changed

ramanpreetSinghKhinda
ramanpreetSinghKhinda reviewed Feb 9, 2021
View reviewed changes
@jeremyjiang-dev
Copy link
Contributor

/test smoke-tests

yingdai3
yingdai3 approved these changes Feb 10, 2021
View reviewed changes
Copy link

@yingdai3 yingdai3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeremyjiang-dev jeremyjiang-dev merged commit a493044 into master Feb 10, 2021
@jeremyjiang-dev jeremyjiang-dev deleted the perf-DIregistrar branch February 10, 2021 22:09
@firebase firebase locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blundell blundell blundell left review comments

@jposuna jposuna jposuna approved these changes

@ramanpreetSinghKhinda ramanpreetSinghKhinda ramanpreetSinghKhinda approved these changes

@yingdai3 yingdai3 yingdai3 approved these changes

@alikn alikn Awaiting requested review from alikn

@jeremyjiang-dev jeremyjiang-dev Awaiting requested review from jeremyjiang-dev

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@visumickey @google-oss-bot @jeremyjiang-dev @jposuna @blundell @ramanpreetSinghKhinda @yingdai3 @googlebot