Skip to content

Adding deleteModel logging and retrieve download success events. #2409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 5, 2021
Merged

Adding deleteModel logging and retrieve download success events. #2409

merged 4 commits into from
Feb 5, 2021

Conversation

annzimmer
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Feb 4, 2021
@google-cla google-cla bot added the cla: yes Override cla label Feb 4, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 4, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-ml-modeldownloader

    SDK overall coverage changed from 84.48% (99c41d7) to 83.97% (07f4b95e) by -0.51%.

    Filename Base (99c41d7) Head (07f4b95e) Diff
    AutoValue_FirebaseMlLogEvent.java 57.45% 58.18% +0.74%
    AutoValue_FirebaseMlLogEvent_DeleteModelLogEvent.java ? 66.67% ?
    CustomModelDownloadService.java 83.80% 82.55% -1.25%
    FirebaseMlLogEvent.java 97.70% 97.92% +0.22%
    FirebaseMlLogger.java 89.00% 87.83% -1.17%
    FirebaseModelDownloader.java 85.12% 85.21% +0.09%
    ModelFileManager.java 81.71% 81.48% -0.23%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (07f4b95e) is created by Prow via merging commits: 99c41d7 7f546c3.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 4, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-ml-modeldownloader

    Type Base (99c41d7) Head (07f4b95e) Diff
    aar 87.7 kB 93.3 kB +5.57 kB (+6.4%)
    apk (aggressive) 128 kB 129 kB +524 B (+0.4%)
    apk (release) 788 kB 789 kB +1.46 kB (+0.2%)

Test Logs

Notes

Head commit (07f4b95e) is created by Prow via merging commits: 99c41d7 7f546c3.

@annzimmer annzimmer marked this pull request as ready for review February 4, 2021 17:16
@annzimmer annzimmer requested a review from rlazo February 4, 2021 17:16
@annzimmer annzimmer merged commit 4a4fbd2 into master Feb 5, 2021
@annzimmer annzimmer deleted the mlEventLogging branch February 5, 2021 14:54
@firebase firebase locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees

@pavelgj pavelgj

@manjanac manjanac

Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@annzimmer @google-oss-bot @rlazo @pavelgj @googlebot @manjanac