Skip to content

add manifest flag for model downloader data collection #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

annzimmer
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-ml-modeldownloader

    Type Base (ce966dd) Head (9f99b414) Diff
    aar 93.7 kB 94.2 kB +476 B (+0.5%)
    apk (release) 789 kB 790 kB +276 B (+0.0%)

Test Logs

Notes

Head commit (9f99b414) is created by Prow via merging commits: ce966dd da94d90.

@annzimmer annzimmer marked this pull request as ready for review February 8, 2021 22:02
@annzimmer annzimmer requested a review from rlazo February 8, 2021 22:03
@annzimmer
Copy link
Contributor Author

Current failing tests seem unrelated.

@rlazo rlazo requested a review from VinayGuthal February 8, 2021 22:35
@rlazo
Copy link
Collaborator

rlazo commented Feb 8, 2021

@VinayGuthal could you PTAL? Thanks!

@annzimmer annzimmer requested review from VinayGuthal and removed request for VinayGuthal February 9, 2021 18:49
@annzimmer
Copy link
Contributor Author

/test smoke-tests

@annzimmer annzimmer merged commit d4c30ec into master Feb 16, 2021
@annzimmer annzimmer deleted the mlLogging branch February 16, 2021 15:54
@firebase firebase locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants