-
Notifications
You must be signed in to change notification settings - Fork 624
Update functions instances used by device-tests and smoke-tests. #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yifanyang
commented
Feb 9, 2021
- upgrade the version of node.js used to build functions from 6 to 12
- add source code for functions instance used by smoke-tests
- upgrade the version of node.js used to build functions from 6 to 12 - add source code for functions instance used by smoke-tests
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (8d593e3d) is created by Prow via merging commits: 0de237d ab53d1f. |
Binary Size ReportAffected SDKsNo changes between base commit (0de237d) and head commit (8d593e3d). Test Logs
NotesHead commit (8d593e3d) is created by Prow via merging commits: 0de237d ab53d1f. |
/test device-check-changed |
2 similar comments
/test device-check-changed |
/test device-check-changed |
"firebase-functions": "^0.5.7" | ||
}, | ||
"devDependencies": { | ||
"@google-cloud/functions-emulator": "1.0.0-beta.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need the emulator anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This npm module has been deprecated: https://www.npmjs.com/package/@google-cloud/functions-emulator. One of the recommended alternative is to start emulator with firebase-tools
, which is the same tool used to deploy functions. So I think it's no longer needed here.
@@ -0,0 +1,29 @@ | |||
const functions = require("firebase-functions"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is actual code, AFAIK it needs the copyright header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@yifanyang: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |