Skip to content

Update functions instances used by device-tests and smoke-tests. #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

yifanyang
Copy link
Contributor

  • upgrade the version of node.js used to build functions from 6 to 12
  • add source code for functions instance used by smoke-tests

- upgrade the version of node.js used to build functions from 6 to 12
- add source code for functions instance used by smoke-tests
@googlebot googlebot added the cla: yes Override cla label Feb 9, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 9, 2021

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.13% (0de237d) to 50.15% (8d593e3d) by +0.02%.

    Filename Base (0de237d) Head (8d593e3d) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    ViewProcessor.java 91.79% 92.10% +0.30%
  • firebase-messaging

    SDK overall coverage changed from 83.56% (0de237d) to 83.43% (8d593e3d) by -0.14%.

    Filename Base (0de237d) Head (8d593e3d) Diff
    TopicsSubscriber.java 91.38% 89.66% -1.72%
  • firebase-storage

    SDK overall coverage changed from 85.48% (0de237d) to 85.43% (8d593e3d) by -0.04%.

    Filename Base (0de237d) Head (8d593e3d) Diff
    UploadTask.java 80.22% 79.85% -0.37%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (8d593e3d) is created by Prow via merging commits: 0de237d ab53d1f.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 9, 2021

Binary Size Report

Affected SDKs

No changes between base commit (0de237d) and head commit (8d593e3d).

Test Logs

Notes

Head commit (8d593e3d) is created by Prow via merging commits: 0de237d ab53d1f.

@yifanyang
Copy link
Contributor Author

/test device-check-changed

2 similar comments
@yifanyang
Copy link
Contributor Author

/test device-check-changed

@yifanyang
Copy link
Contributor Author

/test device-check-changed

@yifanyang yifanyang requested a review from rlazo February 10, 2021 18:03
"firebase-functions": "^0.5.7"
},
"devDependencies": {
"@google-cloud/functions-emulator": "1.0.0-beta.4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the emulator anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This npm module has been deprecated: https://www.npmjs.com/package/@google-cloud/functions-emulator. One of the recommended alternative is to start emulator with firebase-tools, which is the same tool used to deploy functions. So I think it's no longer needed here.

@@ -0,0 +1,29 @@
const functions = require("firebase-functions");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is actual code, AFAIK it needs the copyright header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed ab53d1f link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yifanyang yifanyang merged commit 0d2d21e into master Feb 10, 2021
@yifanyang yifanyang deleted the yifany/functions branch February 10, 2021 19:36
@firebase firebase locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants