Skip to content

add manifest flag unit tests. #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2021
Merged

add manifest flag unit tests. #2446

merged 2 commits into from
Feb 22, 2021

Conversation

annzimmer
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Feb 18, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 18, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.17% (18d574f) to 50.22% (39ce4a56) by +0.04%.

    Filename Base (18d574f) Head (39ce4a56) Diff
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%

  • firebase-perf

    SDK overall coverage changed from 69.86% (18d574f) to 69.84% (39ce4a56) by -0.02%.

    Filename Base (18d574f) Head (39ce4a56) Diff
    TransportManager.java 96.06% 95.57% -0.49%

  • firebase-storage

    SDK overall coverage changed from ? (18d574f) to 85.52% (39ce4a56) by ?.

    Click to show coverage changes in 45 files.
    Filename Base (18d574f) Head (39ce4a56) Diff
    ActivityLifecycleListener.java ? 74.14% ?
    AdaptiveStreamBuffer.java ? 84.62% ?
    CancelException.java ? 100.00% ?
    CancellableTask.java ? 100.00% ?
    ControllableTask.java ? 100.00% ?
    DeleteNetworkRequest.java ? 100.00% ?
    DeleteStorageTask.java ? 100.00% ?
    ExponentialBackoffSender.java ? 86.05% ?
    FileDownloadTask.java ? 78.23% ?
    FirebaseStorage.java ? 84.34% ?
    FirebaseStorageComponent.java ? 100.00% ?
    GetDownloadUrlTask.java ? 96.67% ?
    GetMetadataNetworkRequest.java ? 100.00% ?
    GetMetadataTask.java ? 84.62% ?
    GetNetworkRequest.java ? 100.00% ?
    HttpURLConnectionFactory.java ? 0.00% ?
    HttpURLConnectionFactoryImpl.java ? 50.00% ?
    ListNetworkRequest.java ? 100.00% ?
    ListResult.java ? 100.00% ?
    ListTask.java ? 85.19% ?
    NetworkRequest.java ? 89.29% ?
    OnPausedListener.java ? 0.00% ?
    OnProgressListener.java ? 0.00% ?
    ResumableNetworkRequest.java ? 100.00% ?
    ResumableUploadByteRequest.java ? 90.91% ?
    ResumableUploadCancelRequest.java ? 100.00% ?
    ResumableUploadQueryRequest.java ? 100.00% ?
    ResumableUploadStartRequest.java ? 95.00% ?
    Slashes.java ? 82.35% ?
    Sleeper.java ? 0.00% ?
    SleeperImpl.java ? 33.33% ?
    SmartHandler.java ? 87.50% ?
    StorageException.java ? 65.45% ?
    StorageMetadata.java ? 86.34% ?
    StorageReference.java ? 89.88% ?
    StorageRegistrar.java ? 100.00% ?
    StorageTask.java ? 84.29% ?
    StorageTaskManager.java ? 100.00% ?
    StorageTaskScheduler.java ? 100.00% ?
    StreamDownloadTask.java ? 88.89% ?
    TaskListenerImpl.java ? 100.00% ?
    UpdateMetadataNetworkRequest.java ? 100.00% ?
    UpdateMetadataTask.java ? 80.00% ?
    UploadTask.java ? 80.22% ?
    Util.java ? 65.57% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (39ce4a56) is created by Prow via merging commits: 18d574f c8f8065.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 18, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-ml-modeldownloader

    Type Base (18d574f) Head (39ce4a56) Diff
    aar 94.2 kB 94.2 kB +2 B (+0.0%)

Test Logs

Notes

Head commit (39ce4a56) is created by Prow via merging commits: 18d574f c8f8065.

@annzimmer
Copy link
Contributor Author

/retest

2 similar comments
@annzimmer
Copy link
Contributor Author

/retest

@annzimmer
Copy link
Contributor Author

/retest

@annzimmer annzimmer marked this pull request as ready for review February 18, 2021 22:22
@annzimmer annzimmer self-assigned this Feb 18, 2021
rlazo
rlazo reviewed Feb 18, 2021
View reviewed changes
firebase-ml-modeldownloader/ml-data-collection-tests/ml-data-collection-tests.gradle
dependencies {
implementation project(':encoders:firebase-encoders')
implementation project(':encoders:firebase-encoders-json')
implementation project(':firebase-common')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all these dependencies necessary for the actual implementation of the test? Otherwise I think you can get away with just depending on common (for firebaseApp) and mldownloader.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

firebase-ml-modeldownloader/ml-data-collection-tests/ml-data-collection-tests.gradle Outdated
testImplementation 'androidx.test:runner:1.2.0'
testImplementation 'androidx.test.ext:junit:1.1.1'
testImplementation "org.robolectric:robolectric:$robolectricVersion"
testImplementation 'com.google.auto.value:auto-value-annotations:1.6.5'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK you're not using autovalues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

...t/java/com/google/firebase/ml_data_collection_tests/MlDataCollectionDefaultDisabledTest.java Outdated
@@ -0,0 +1,63 @@
// Copyright 2019 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

...sts/src/test/java/com/google/firebase/ml_data_collection_tests/MlDataCollectionTestUtil.java Outdated
@@ -0,0 +1,61 @@
// Copyright 2019 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@annzimmer
Copy link
Contributor Author

/test device-check-changed

1 similar comment
@annzimmer
Copy link
Contributor Author

/test device-check-changed

@google-oss-bot
Copy link
Contributor

@annzimmer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed c8f8065 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@annzimmer annzimmer merged commit f56a977 into master Feb 22, 2021
@annzimmer annzimmer deleted the mlFunctional branch February 22, 2021 16:39
@firebase firebase locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees

@annzimmer annzimmer

Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annzimmer @google-oss-bot @rlazo @VinayGuthal