Skip to content

Add dummy task in javadoc plugin to generate an empty api.txt file #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Feb 18, 2021

Also add support for formatting plugin in buildSrc.

Also add support for formatting plugin in buildSrc.
@googlebot googlebot added the cla: yes Override cla label Feb 18, 2021
@rlazo rlazo requested a review from VinayGuthal February 18, 2021 15:33
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.21% (3f237a3) to 50.15% (0baf9b34) by -0.06%.

    Filename Base (3f237a3) Head (0baf9b34) Diff
    ChildChangeAccumulator.java 96.67% 83.33% -13.33%
    DoubleNode.java 100.00% 88.24% -11.76%
    ViewProcessor.java 91.79% 92.10% +0.30%
  • firebase-messaging

    SDK overall coverage changed from ? (3f237a3) to 83.56% (0baf9b34) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (3f237a3) Head (0baf9b34) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 65.00% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 94.79% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 63.93% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 95.48% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 91.38% ?
    TopicsSyncTask.java ? 53.33% ?
  • firebase-perf

    SDK overall coverage changed from 69.86% (3f237a3) to 69.84% (0baf9b34) by -0.02%.

    Filename Base (3f237a3) Head (0baf9b34) Diff
    TransportManager.java 96.06% 95.57% -0.49%
  • firebase-storage

    SDK overall coverage changed from 85.88% (3f237a3) to 85.52% (0baf9b34) by -0.36%.

    Filename Base (3f237a3) Head (0baf9b34) Diff
    StorageException.java 69.09% 65.45% -3.64%
    StorageTask.java 84.89% 84.29% -0.60%
    StreamDownloadTask.java 88.41% 88.89% +0.48%
    UploadTask.java 82.05% 80.22% -1.83%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (0baf9b34) is created by Prow via merging commits: 3f237a3 56826c5.

@rlazo
Copy link
Collaborator Author

rlazo commented Feb 18, 2021

@yifanyang FYI All changes in this PR are in the buildSrc subdir, but somehow the coverage report points to a significant drop in coverage for firebase-database

@rlazo
Copy link
Collaborator Author

rlazo commented Feb 18, 2021

/test check-changed

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (3f237a3) and head commit (0baf9b34).

Test Logs

Notes

Head commit (0baf9b34) is created by Prow via merging commits: 3f237a3 56826c5.

@rlazo
Copy link
Collaborator Author

rlazo commented Feb 18, 2021

/test check-changed

@rlazo
Copy link
Collaborator Author

rlazo commented Feb 18, 2021

/test device-check-changed

@rlazo rlazo merged commit b9525bb into master Feb 18, 2021
@rlazo rlazo deleted the rl.fixjavadoc9284 branch February 18, 2021 16:10
@google-oss-bot
Copy link
Contributor

@rlazo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 56826c5 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants