Skip to content

First commit, removed root files and moved configuration to BomGenera… #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2021
Merged

First commit, removed root files and moved configuration to BomGenera… #2454

merged 4 commits into from
Feb 19, 2021

Conversation

davidmotson
Copy link
Collaborator

…torTask

@googlebot googlebot added the cla: yes Override cla label Feb 19, 2021
@davidmotson davidmotson requested a review from rlazo February 19, 2021 19:24
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 19, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.13% (34bf6dc) to 50.18% (90ebbe4f) by +0.06%.

    Filename Base (34bf6dc) Head (90ebbe4f) Diff
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%
    DoubleNode.java 100.00% 88.24% -11.76%
    SyncTree.java 56.35% 57.24% +0.89%
    ViewProcessor.java 92.10% 91.79% -0.30%

  • firebase-storage

    SDK overall coverage changed from 85.48% (34bf6dc) to 85.88% (90ebbe4f) by +0.40%.

    Filename Base (34bf6dc) Head (90ebbe4f) Diff
    StorageException.java 65.45% 69.09% +3.64%
    StorageTask.java 84.29% 84.89% +0.60%
    StreamDownloadTask.java 88.41% 88.89% +0.48%
    UploadTask.java 80.22% 81.68% +1.47%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (90ebbe4f) is created by Prow via merging commits: 34bf6dc c04704f.

rlazo
rlazo approved these changes Feb 19, 2021
View reviewed changes
buildSrc/src/main/java/com/google/firebase/gradle/bomgenerator/BomGeneratorTask.java Outdated
Comment on lines 14 to 16


package com.google.firebase.gradle.bomgenerator;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package com.google.firebase.gradle.bomgenerator;
package com.google.firebase.gradle.bomgenerator;

@rlazo
Copy link
Collaborator

rlazo commented Feb 19, 2021

Tests are failing because of:

* What went wrong:
Execution failed for task ':buildSrc:verifyGoogleJavaFormat'.
> Problems: formatting style violations

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (34bf6dc) and head commit (90ebbe4f).

Test Logs

Notes

Head commit (90ebbe4f) is created by Prow via merging commits: 34bf6dc c04704f.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 19, 2021 •
edited
Loading

@davidmotson: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed c04704f link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo
Copy link
Collaborator

rlazo commented Feb 19, 2021

/test check-changed

@rlazo rlazo merged commit ce5e01b into master Feb 19, 2021
@rlazo rlazo deleted the davidmotson.bom_generator branch February 19, 2021 21:47
@firebase firebase locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidmotson @google-oss-bot @rlazo @googlebot