Skip to content

Removing the isPerformanceMonitoringEnabled check in FirebasePerfProvider and moving the getSharedPreferences to a separate thread. #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2021
Merged

Removing the isPerformanceMonitoringEnabled check in FirebasePerfProvider and moving the getSharedPreferences to a separate thread. #2458

merged 1 commit into from
Feb 23, 2021

Conversation

raymondlam
Copy link
Member

To address StrictMode violation in b/171411615.

@raymondlam
Removing the isPerformanceMonitoringEnabled check in FirebasePerfProv…
194939c 
…ider and moving the getSharedPreferences to a separate thread.

To address StrictMode violation in b/171411615.
@googlebot googlebot added the cla: yes Override cla label Feb 22, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-perf

    SDK overall coverage changed from ? (f56a977) to 69.75% (1426c0d5) by ?.

    Click to show coverage changes in 94 files.
    Filename Base (f56a977) Head (1426c0d5) Diff
    AddTrace.java ? 0.00% ?
    AndroidApplicationInfo.java ? 34.71% ?
    AndroidApplicationInfoOrBuilder.java ? 0.00% ?
    AndroidLogger.java ? 97.78% ?
    AndroidMemoryReading.java ? 38.36% ?
    AndroidMemoryReadingOrBuilder.java ? 0.00% ?
    AppStartTrace.java ? 82.65% ?
    AppStateMonitor.java ? 85.71% ?
    AppStateUpdateHandler.java ? 92.59% ?
    ApplicationInfo.java ? 45.00% ?
    ApplicationInfoOrBuilder.java ? 0.00% ?
    ApplicationProcessState.java ? 73.91% ?
    Clock.java ? 100.00% ?
    ConfigResolver.java ? 97.24% ?
    ConfigurationConstants.java ? 99.21% ?
    ConfigurationFlag.java ? 100.00% ?
    Constants.java ? 95.65% ?
    Counter.java ? 90.91% ?
    CpuGaugeCollector.java ? 91.95% ?
    CpuMetricReading.java ? 39.33% ?
    CpuMetricReadingOrBuilder.java ? 0.00% ?
    DaggerFirebasePerformanceComponent.java ? 100.00% ?
    DeviceCacheManager.java ? 76.03% ?
    FirebasePerfApplicationInfoValidator.java ? 92.86% ?
    FirebasePerfGaugeMetricValidator.java ? 100.00% ?
    FirebasePerfHttpClient.java ? 93.85% ?
    FirebasePerfMetricProto.java ? 0.00% ?
    FirebasePerfNetworkValidator.java ? 86.81% ?
    FirebasePerfOkHttpClient.java ? 44.90% ?
    FirebasePerfProvider.java ? 75.00% ?
    FirebasePerfRegistrar.java ? 100.00% ?
    FirebasePerfTraceValidator.java ? 88.24% ?
    FirebasePerfUrlConnection.java ? 44.26% ?
    FirebasePerformance.java ? 82.95% ?
    FirebasePerformanceAttributable.java ? 0.00% ?
    FirebasePerformanceComponent.java ? 0.00% ?
    FirebasePerformanceModule.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesGaugeManagerFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java ? 16.67% ?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java ? 16.67% ?
    FirebasePerformance_Factory.java ? 8.33% ?
    FlgTransport.java ? 83.33% ?
    GaugeManager.java ? 98.39% ?
    GaugeMetadata.java ? 32.21% ?
    GaugeMetadataManager.java ? 84.62% ?
    GaugeMetadataOrBuilder.java ? 0.00% ?
    GaugeMetric.java ? 39.47% ?
    GaugeMetricOrBuilder.java ? 0.00% ?
    HttpMetric.java ? 91.78% ?
    ImmutableBundle.java ? 100.00% ?
    InstrHttpInputStream.java ? 92.86% ?
    InstrHttpOutputStream.java ? 98.00% ?
    InstrHttpURLConnection.java ? 93.42% ?
    InstrHttpsURLConnection.java ? 94.32% ?
    InstrURLConnectionBase.java ? 95.22% ?
    InstrumentApacheHttpResponseHandler.java ? 100.00% ?
    InstrumentOkHttpEnqueueCallback.java ? 100.00% ?
    LogWrapper.java ? 23.08% ?
    MemoryGaugeCollector.java ? 90.00% ?
    NetworkConnectionInfo.java ? 0.00% ?
    NetworkConnectionInfoOrBuilder.java ? 0.00% ?
    NetworkRequestMetric.java ? 49.16% ?
    NetworkRequestMetricBuilder.java ? 96.00% ?
    NetworkRequestMetricBuilderUtil.java ? 75.00% ?
    NetworkRequestMetricOrBuilder.java ? 0.00% ?
    Optional.java ? 86.67% ?
    PendingPerfEvent.java ? 100.00% ?
    PerfMetric.java ? 33.67% ?
    PerfMetricOrBuilder.java ? 0.00% ?
    PerfMetricValidator.java ? 90.32% ?
    PerfSession.java ? 93.65% ?
    PerfSessionOrBuilder.java ? 0.00% ?
    RateLimiter.java ? 90.27% ?
    RemoteConfigManager.java ? 92.24% ?
    ResourceType.java ? 0.00% ?
    SessionAwareObject.java ? 0.00% ?
    SessionManager.java ? 100.00% ?
    SessionVerbosity.java ? 68.42% ?
    StorageUnit.java ? 57.89% ?
    Timer.java ? 93.75% ?
    Trace.java ? 96.69% ?
    TraceMetric.java ? 43.42% ?
    TraceMetricBuilder.java ? 100.00% ?
    TraceMetricOrBuilder.java ? 0.00% ?
    TransportInfo.java ? 0.00% ?
    TransportInfoOrBuilder.java ? 0.00% ?
    TransportManager.java ? 95.57% ?
    URLAllowlist.java ? 94.44% ?
    URLWrapper.java ? 0.00% ?
    Utils.java ? 78.57% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (1426c0d5) is created by Prow via merging commits: f56a977 194939c.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 13.8 kB ? (?)
    apk (aggressive) ? 78.5 kB ? (?)
    apk (release) ? 640 kB ? (?)

  • firebase-annotations

    Type Base (f56a977) Head (1426c0d5) Diff
    apk (aggressive) ? 8.39 kB ? (?)
    apk (release) ? 8.77 kB ? (?)

  • firebase-common

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 50.1 kB ? (?)
    apk (aggressive) ? 77.9 kB ? (?)
    apk (release) ? 635 kB ? (?)

  • firebase-components

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 46.3 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 29.2 kB ? (?)

  • firebase-config

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 71.6 kB ? (?)
    apk (aggressive) ? 91.2 kB ? (?)
    apk (release) ? 718 kB ? (?)

  • firebase-datatransport

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 5.04 kB ? (?)
    apk (aggressive) ? 114 kB ? (?)
    apk (release) ? 704 kB ? (?)

  • firebase-encoders

    Type Base (f56a977) Head (1426c0d5) Diff
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 15.3 kB ? (?)

  • firebase-encoders-json

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 11.8 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 20.0 kB ? (?)

  • firebase-installations

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 56.7 kB ? (?)
    apk (aggressive) ? 79.6 kB ? (?)
    apk (release) ? 657 kB ? (?)

  • firebase-installations-interop

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 8.05 kB ? (?)
    apk (aggressive) ? 55.4 kB ? (?)
    apk (release) ? 607 kB ? (?)

  • firebase-perf

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 303 kB ? (?)
    apk (aggressive) ? 967 kB ? (?)
    apk (release) ? 2.43 MB ? (?)

  • protolite-well-known-types

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 1.00 MB ? (?)
    apk (aggressive) ? 134 kB ? (?)
    apk (release) ? 661 kB ? (?)

  • transport-api

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 6.59 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 14.8 kB ? (?)

  • transport-backend-cct

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 54.4 kB ? (?)
    apk (aggressive) ? 47.3 kB ? (?)
    apk (release) ? 87.0 kB ? (?)

  • transport-runtime

    Type Base (f56a977) Head (1426c0d5) Diff
    aar ? 164 kB ? (?)
    apk (aggressive) ? 33.2 kB ? (?)
    apk (release) ? 63.2 kB ? (?)

Test Logs

Notes

Head commit (1426c0d5) is created by Prow via merging commits: f56a977 194939c.

@raymondlam
Copy link
Member Author

/test smoke-tests

@ramanpreetSinghKhinda ramanpreetSinghKhinda merged commit 7b9b80e into firebase:master Feb 23, 2021
@firebase firebase locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramanpreetSinghKhinda ramanpreetSinghKhinda ramanpreetSinghKhinda approved these changes

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raymondlam @google-oss-bot @ramanpreetSinghKhinda @jeremyjiang-dev @googlebot