Skip to content

Accept Proto3 JSON limits in Bundled Queries #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 48.67% (7b9b80e) to 48.72% (cf99006d) by +0.05%.

    Filename Base (7b9b80e) Head (cf99006d) Diff
    BundleSerializer.java 88.98% 89.08% +0.09%
    GrpcCallProvider.java 57.95% 68.18% +10.23%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (cf99006d) is created by Prow via merging commits: 7b9b80e eecd025.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (7b9b80e) Head (cf99006d) Diff
    aar 1.10 MB 1.10 MB -2 B (-0.0%)
    apk (release) 3.19 MB 3.19 MB +100 B (+0.0%)

Test Logs

Notes

Head commit (cf99006d) is created by Prow via merging commits: 7b9b80e eecd025.

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Feb 24, 2021
@schmidt-sebastian schmidt-sebastian merged commit ce1a078 into master Feb 24, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/limits branch February 24, 2021 21:41
@firebase firebase locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants