Skip to content

Add @Singleton annotation to FirebasePerformance class and component. #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2021
Merged

Add @Singleton annotation to FirebasePerformance class and component. #2467

merged 2 commits into from
Mar 1, 2021

Conversation

visumickey
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Feb 25, 2021
@visumickey visumickey changed the title Add @singelton annotation to FirebasePerformance class and component. Add @Singleton annotation to FirebasePerformance class and component. Feb 25, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-perf

    SDK overall coverage changed from 69.75% (76ec3e8) to 70.56% (5a685c91) by +0.81%.

    Filename Base (76ec3e8) Head (5a685c91) Diff
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java 16.67% 100.00% +83.33%
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java 16.67% 100.00% +83.33%
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java 16.67% 100.00% +83.33%
    FirebasePerformanceModule_ProvidesGaugeManagerFactory.java 16.67% 100.00% +83.33%
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java 16.67% 100.00% +83.33%
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java 16.67% 100.00% +83.33%
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java 16.67% 100.00% +83.33%
    FirebasePerformance_Factory.java 8.33% 100.00% +91.67%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (5a685c91) is created by Prow via merging commits: 76ec3e8 d046f1e.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-perf

    Type Base (76ec3e8) Head (5a685c91) Diff
    aar 303 kB 303 kB +421 B (+0.1%)
    apk (aggressive) 967 kB 968 kB +1.23 kB (+0.1%)
    apk (release) 2.43 MB 2.43 MB +136 B (+0.0%)

Test Logs

Notes

Head commit (5a685c91) is created by Prow via merging commits: 76ec3e8 d046f1e.

@visumickey
Copy link
Contributor Author

/test smoke-tests

@visumickey
Copy link
Contributor Author

/test smoke-tests

@visumickey visumickey merged commit ea89473 into master Mar 1, 2021
@visumickey visumickey deleted the perfSingletonPerformance branch March 1, 2021 19:44
@firebase firebase locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramanpreetSinghKhinda ramanpreetSinghKhinda ramanpreetSinghKhinda left review comments

@vkryachko vkryachko vkryachko approved these changes

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev approved these changes

@rlazo rlazo Awaiting requested review from rlazo

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@visumickey @google-oss-bot @vkryachko @ramanpreetSinghKhinda @jeremyjiang-dev