Skip to content

Key key -> key #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2021
Merged

Key key -> key #2493

merged 1 commit into from
Mar 10, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Mar 9, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from ? (7bcedca) to 50.17% (be20c308) by ?.

    Click to show coverage changes in 154 files.
    Filename Base (7bcedca) Head (be20c308) Diff
    AckUserWrite.java ? 88.89% ?
    AndroidAuthTokenProvider.java ? 42.31% ?
    AndroidEventTarget.java ? 42.86% ?
    AndroidLogger.java ? 45.45% ?
    AndroidPlatform.java ? 39.02% ?
    AuthTokenProvider.java ? 0.00% ?
    BooleanNode.java ? 100.00% ?
    CacheNode.java ? 100.00% ?
    CachePolicy.java ? 50.00% ?
    CancelEvent.java ? 0.00% ?
    Change.java ? 91.67% ?
    ChildChangeAccumulator.java ? 96.67% ?
    ChildEventListener.java ? 0.00% ?
    ChildEventRegistration.java ? 0.00% ?
    ChildKey.java ? 90.00% ?
    ChildrenNode.java ? 73.40% ?
    Clock.java ? 0.00% ?
    CompoundHash.java ? 0.00% ?
    CompoundWrite.java ? 87.85% ?
    Connection.java ? 27.59% ?
    ConnectionAuthTokenProvider.java ? 0.00% ?
    ConnectionContext.java ? 88.89% ?
    ConnectionUtils.java ? 7.14% ?
    Constants.java ? 0.00% ?
    Context.java ? 75.93% ?
    CustomClassMapper.java ? 88.33% ?
    DataEvent.java ? 70.00% ?
    DataSnapshot.java ? 54.05% ?
    DatabaseConfig.java ? 63.04% ?
    DatabaseError.java ? 0.00% ?
    DatabaseException.java ? 50.00% ?
    DatabaseReference.java ? 23.36% ?
    DatabaseRegistrar.java ? 100.00% ?
    DefaultClock.java ? 100.00% ?
    DefaultLogger.java ? 66.67% ?
    DefaultPersistenceManager.java ? 74.76% ?
    DefaultRunLoop.java ? 57.14% ?
    DeferredValueNode.java ? 0.00% ?
    DoubleNode.java ? 100.00% ?
    EmptyNode.java ? 83.33% ?
    Event.java ? 100.00% ?
    EventGenerator.java ? 100.00% ?
    EventRaiser.java ? 25.00% ?
    EventRegistration.java ? 41.18% ?
    EventRegistrationZombieListener.java ? 0.00% ?
    EventTarget.java ? 0.00% ?
    Exclude.java ? 0.00% ?
    FirebaseDatabase.java ? 29.76% ?
    FirebaseDatabaseComponent.java ? 100.00% ?
    GAuthToken.java ? 81.82% ?
    GenericTypeIndicator.java ? 100.00% ?
    HostInfo.java ? 85.71% ?
    IgnoreExtraProperties.java ? 0.00% ?
    ImmutableTree.java ? 84.52% ?
    Index.java ? 53.33% ?
    IndexedFilter.java ? 93.62% ?
    IndexedNode.java ? 95.71% ?
    InternalHelpers.java ? 60.00% ?
    JsonMapper.java ? 59.32% ?
    KeyIndex.java ? 81.82% ?
    LRUCachePolicy.java ? 0.00% ?
    LeafNode.java ? 91.55% ?
    LimitedFilter.java ? 97.67% ?
    ListenComplete.java ? 0.00% ?
    ListenHashProvider.java ? 0.00% ?
    LogWrapper.java ? 71.43% ?
    Logger.java ? 100.00% ?
    LongNode.java ? 93.75% ?
    Merge.java ? 81.25% ?
    MessageBuilderFactory.java ? 0.00% ?
    MutableData.java ? 72.00% ?
    NameAndPriority.java ? 0.00% ?
    NamedNode.java ? 66.67% ?
    Node.java ? 50.00% ?
    NodeAndPath.java ? 0.00% ?
    NodeFilter.java ? 0.00% ?
    NodeSizeEstimator.java ? 0.00% ?
    NodeUtilities.java ? 74.14% ?
    NoopPersistenceManager.java ? 77.50% ?
    NotNull.java ? 0.00% ?
    Nullable.java ? 0.00% ?
    OffsetClock.java ? 75.00% ?
    OnDisconnect.java ? 0.00% ?
    Operation.java ? 100.00% ?
    OperationSource.java ? 94.12% ?
    Overwrite.java ? 80.00% ?
    Pair.java ? 30.00% ?
    ParsedUrl.java ? 66.67% ?
    Path.java ? 87.12% ?
    PathAndId.java ? 0.00% ?
    PathIndex.java ? 92.31% ?
    PersistenceManager.java ? 0.00% ?
    PersistenceStorageEngine.java ? 0.00% ?
    PersistentConnection.java ? 0.00% ?
    PersistentConnectionImpl.java ? 15.70% ?
    Platform.java ? 0.00% ?
    Predicate.java ? 100.00% ?
    PriorityIndex.java ? 83.33% ?
    PriorityUtilities.java ? 76.92% ?
    PropertyName.java ? 0.00% ?
    PruneForest.java ? 76.06% ?
    PushIdGenerator.java ? 84.13% ?
    Query.java ? 44.22% ?
    QueryParams.java ? 89.76% ?
    QuerySpec.java ? 88.46% ?
    RangeMerge.java ? 0.00% ?
    RangedFilter.java ? 100.00% ?
    Repo.java ? 9.96% ?
    RepoInfo.java ? 71.88% ?
    RepoManager.java ? 32.88% ?
    RequestResultCallback.java ? 0.00% ?
    RetryHelper.java ? 70.97% ?
    RunLoop.java ? 0.00% ?
    ServerValue.java ? 0.00% ?
    ServerValues.java ? 50.00% ?
    SnapshotHolder.java ? 100.00% ?
    SparseSnapshotTree.java ? 17.86% ?
    SqlPersistenceStorageEngine.java ? 0.00% ?
    StringListReader.java ? 0.00% ?
    StringNode.java ? 87.50% ?
    SyncPoint.java ? 88.79% ?
    SyncTree.java ? 57.24% ?
    Tag.java ? 71.43% ?
    ThreadBackgroundExecutor.java ? 0.00% ?
    ThreadInitializer.java ? 100.00% ?
    ThreadPoolEventTarget.java ? 0.00% ?
    ThrowOnExtraProperties.java ? 0.00% ?
    TrackedQuery.java ? 46.15% ?
    TrackedQueryManager.java ? 99.45% ?
    Transaction.java ? 0.00% ?
    Tree.java ? 50.00% ?
    TreeNode.java ? 25.00% ?
    UserWriteRecord.java ? 57.14% ?
    Utilities.java ? 68.99% ?
    Validation.java ? 42.67% ?
    ValidationPath.java ? 86.96% ?
    ValueEventListener.java ? 0.00% ?
    ValueEventRegistration.java ? 0.00% ?
    ValueIndex.java ? 0.00% ?
    ValueProvider.java ? 50.00% ?
    View.java ? 85.11% ?
    ViewCache.java ? 100.00% ?
    ViewProcessor.java ? 92.10% ?
    WebSocket.java ? 34.50% ?
    WebSocketEventHandler.java ? 0.00% ?
    WebSocketException.java ? 50.00% ?
    WebSocketHandshake.java ? 26.67% ?
    WebSocketMessage.java ? 0.00% ?
    WebSocketReceiver.java ? 12.82% ?
    WebSocketWriter.java ? 19.23% ?
    WebsocketConnection.java ? 32.39% ?
    WriteTree.java ? 76.67% ?
    WriteTreeRef.java ? 100.00% ?
    ZombieEventManager.java ? 0.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (be20c308) is created by Prow via merging commits: 7bcedca 348a03b.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-annotations

    Type Base (7bcedca) Head (be20c308) Diff
    apk (aggressive) ? 8.39 kB ? (?)
    apk (release) ? 8.77 kB ? (?)

  • firebase-common

    Type Base (7bcedca) Head (be20c308) Diff
    aar ? 50.1 kB ? (?)
    apk (aggressive) ? 77.9 kB ? (?)
    apk (release) ? 635 kB ? (?)

  • firebase-components

    Type Base (7bcedca) Head (be20c308) Diff
    aar ? 46.3 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 29.2 kB ? (?)

  • firebase-database

    Type Base (7bcedca) Head (be20c308) Diff
    aar ? 493 kB ? (?)
    apk (aggressive) ? 283 kB ? (?)
    apk (release) ? 1.09 MB ? (?)

  • firebase-database-collection

    Type Base (7bcedca) Head (be20c308) Diff
    aar ? 34.2 kB ? (?)
    apk (aggressive) ? 268 kB ? (?)
    apk (release) ? 901 kB ? (?)

Test Logs

Notes

Head commit (be20c308) is created by Prow via merging commits: 7bcedca 348a03b.

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 348a03b link /test device-check-changed
smoke-tests 348a03b link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian schmidt-sebastian merged commit fa06750 into master Mar 10, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/keykey branch March 10, 2021 17:04
@firebase firebase locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachelsaunders rachelsaunders rachelsaunders approved these changes

Assignees

@rachelsaunders rachelsaunders

Labels
api: database cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @rachelsaunders