Skip to content

refactor to not use static Contexts from RuntimeEnvironment #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2021

Conversation

dmeng
Copy link
Contributor

@dmeng dmeng commented Mar 16, 2021

Cleaning up some deprecated code usage

@googlebot googlebot added the cla: yes Override cla label Mar 16, 2021
@google-cla google-cla bot added the cla: yes Override cla label Mar 16, 2021
@google-oss-bot
Copy link
Contributor

Hi @dmeng. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vkryachko
Copy link
Member

/ok-to-test

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 17, 2021

Coverage Report

Affected SDKs

  • firebase-messaging

    SDK overall coverage changed from ? (39ce055) to 83.43% (656cbddf) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (39ce055) Head (656cbddf) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 65.00% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 94.79% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 63.93% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 95.48% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 89.66% ?
    TopicsSyncTask.java ? 53.33% ?
  • firebase-perf

    SDK overall coverage changed from 70.58% (39ce055) to 70.60% (656cbddf) by +0.02%.

    Filename Base (39ce055) Head (656cbddf) Diff
    AppStartTrace.java 82.65% 85.71% +3.06%
    TransportManager.java 95.10% 94.12% -0.98%
  • firebase-storage

    SDK overall coverage changed from 85.70% (39ce055) to 85.61% (656cbddf) by -0.09%.

    Filename Base (39ce055) Head (656cbddf) Diff
    UploadTask.java 80.95% 80.22% -0.73%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (656cbddf) is created by Prow via merging commits: 39ce055 7b72c82.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 17, 2021

Binary Size Report

Affected SDKs

No changes between base commit (39ce055) and head commit (656cbddf).

Test Logs

Notes

Head commit (656cbddf) is created by Prow via merging commits: 39ce055 7b72c82.

@dmeng
Copy link
Contributor Author

dmeng commented Mar 17, 2021

/retest

@vkryachko
Copy link
Member

/retest

@google-oss-bot
Copy link
Contributor

@dmeng: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 7b72c82 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VinayGuthal VinayGuthal merged commit 40df7c8 into firebase:master Apr 20, 2021
@firebase firebase locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants