-
Notifications
You must be signed in to change notification settings - Fork 627
refactor to not use static Contexts from RuntimeEnvironment #2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @dmeng. Thanks for your PR. I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (656cbddf) is created by Prow via merging commits: 39ce055 7b72c82. |
Binary Size ReportAffected SDKsNo changes between base commit (39ce055) and head commit (656cbddf). Test Logs
NotesHead commit (656cbddf) is created by Prow via merging commits: 39ce055 7b72c82. |
/retest |
/retest |
@dmeng: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Cleaning up some deprecated code usage