Skip to content

Move Validators classes to its own package. #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2021
Merged

Move Validators classes to its own package. #2523

merged 4 commits into from
Mar 19, 2021

Conversation

visumickey
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Mar 17, 2021
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-perf:
error: Added package com.google.firebase.perf.validator [AddedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 17, 2021 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (5efbe5f) and head commit (0ead48f1).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (0ead48f1) is created by Prow via merging commits: 5efbe5f 5a77201.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 17, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 13.8 kB ? (?)
    apk (aggressive) ? 78.5 kB ? (?)
    apk (release) ? 640 kB ? (?)

  • firebase-annotations

    Type Base (5efbe5f) Head (0ead48f1) Diff
    apk (aggressive) ? 8.39 kB ? (?)
    apk (release) ? 8.77 kB ? (?)

  • firebase-common

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 50.1 kB ? (?)
    apk (aggressive) ? 77.9 kB ? (?)
    apk (release) ? 635 kB ? (?)

  • firebase-components

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 46.3 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 29.2 kB ? (?)

  • firebase-config

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 71.6 kB ? (?)
    apk (aggressive) ? 91.2 kB ? (?)
    apk (release) ? 718 kB ? (?)

  • firebase-datatransport

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 5.04 kB ? (?)
    apk (aggressive) ? 114 kB ? (?)
    apk (release) ? 704 kB ? (?)

  • firebase-encoders

    Type Base (5efbe5f) Head (0ead48f1) Diff
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 15.3 kB ? (?)

  • firebase-encoders-json

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 11.8 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 20.0 kB ? (?)

  • firebase-installations

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 56.7 kB ? (?)
    apk (aggressive) ? 79.6 kB ? (?)
    apk (release) ? 657 kB ? (?)

  • firebase-installations-interop

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 8.05 kB ? (?)
    apk (aggressive) ? 55.4 kB ? (?)
    apk (release) ? 607 kB ? (?)

  • firebase-perf

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 303 kB ? (?)
    apk (aggressive) ? 968 kB ? (?)
    apk (release) ? 2.43 MB ? (?)

  • protolite-well-known-types

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 1.00 MB ? (?)
    apk (aggressive) ? 134 kB ? (?)
    apk (release) ? 661 kB ? (?)

  • transport-api

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 6.59 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 14.8 kB ? (?)

  • transport-backend-cct

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 54.4 kB ? (?)
    apk (aggressive) ? 47.3 kB ? (?)
    apk (release) ? 87.0 kB ? (?)

  • transport-runtime

    Type Base (5efbe5f) Head (0ead48f1) Diff
    aar ? 164 kB ? (?)
    apk (aggressive) ? 33.2 kB ? (?)
    apk (release) ? 63.2 kB ? (?)

Test Logs

Notes

Head commit (0ead48f1) is created by Prow via merging commits: 5efbe5f 5a77201.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-perf:
error: Added package com.google.firebase.perf.metrics.validator [AddedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@visumickey visumickey requested a review from vkryachko March 18, 2021 22:16
@visumickey
Copy link
Contributor Author

/test check-changed

@visumickey visumickey merged commit 948896a into master Mar 19, 2021
@visumickey visumickey deleted the perfPackageMoveValidators branch March 19, 2021 00:50
@firebase firebase locked and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev approved these changes

@ramanpreetSinghKhinda ramanpreetSinghKhinda Awaiting requested review from ramanpreetSinghKhinda

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@visumickey @google-oss-bot @vkryachko @jeremyjiang-dev @googlebot