Skip to content

Create a separate package for Application Handlers #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2021

Conversation

visumickey
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 19, 2021

Coverage Report

Affected SDKs

  • firebase-perf

    SDK overall coverage changed from 70.55% (cdc3aff) to 70.52% (b128a2b6) by -0.03%.

    Filename Base (cdc3aff) Head (b128a2b6) Diff
    TransportManager.java 95.57% 94.58% -0.99%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (b128a2b6) is created by Prow via merging commits: cdc3aff e1ba454.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-perf:
error: Added class com.google.firebase.perf.metrics.ResourceType [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 19, 2021

Binary Size Report

Affected SDKs

  • firebase-perf

    Type Base (cdc3aff) Head (b128a2b6) Diff
    aar 303 kB 303 kB +84 B (+0.0%)
    apk (aggressive) 968 kB 968 kB +4 B (+0.0%)
    apk (release) 2.43 MB 2.43 MB -4 B (-0.0%)
  • firebase-perf-ktx

    Type Base (cdc3aff) Head (b128a2b6) Diff
    apk (aggressive) 984 kB 984 kB -16 B (-0.0%)
    apk (release) 2.91 MB 2.91 MB +56 B (+0.0%)

Test Logs

Notes

Head commit (b128a2b6) is created by Prow via merging commits: cdc3aff e1ba454.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-perf:
error: Added class com.google.firebase.perf.metrics.ResourceType [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

Copy link
Contributor

@jeremyjiang-dev jeremyjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we should rename resource folder to resourcetype. resouce folder makes me think about Android resource, such as layout.

@visumickey
Copy link
Contributor Author

LGTM. I wonder if we should rename resource folder to resourcetype. resouce folder makes me think about Android resource, such as layout.

Interesting comment. Good point. May be as a part of the code convention change, we can call it as MetricType that would make it easier to understand. I agree resource is quite confusing.

@visumickey visumickey merged commit 42308d8 into master Mar 19, 2021
@visumickey visumickey deleted the perfPackageCleanup branch March 19, 2021 18:54
@firebase firebase locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants