-
Notifications
You must be signed in to change notification settings - Fork 627
Create a separate package for Application Handlers #2527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (b128a2b6) is created by Prow via merging commits: cdc3aff e1ba454. |
The public api surface has changed for the subproject firebase-perf: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (b128a2b6) is created by Prow via merging commits: cdc3aff e1ba454. |
The public api surface has changed for the subproject firebase-perf: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
…manage the access permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I wonder if we should rename resource
folder to resourcetype
. resouce
folder makes me think about Android resource, such as layout.
Interesting comment. Good point. May be as a part of the code convention change, we can call it as MetricType that would make it easier to understand. I agree resource is quite confusing. |
No description provided.