-
Notifications
You must be signed in to change notification settings - Fork 627
Create native proxy object to check provider on each call and mediate… #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4846448
Create native proxy object to check provider on each call and mediate…
e15dc54
2nd push to fix import
83e46af
fix tests
32b0737
fix writeSessionApp
b2ea9be
googleJavaFormat
d15c27e
fix typo
a38ce75
typo fix v2
54bd3be
added tests
5a20eb9
add copyright to tests
7efd669
UJpdate test name
180132e
add junitrunner
b81a009
Merge branch 'master' into davidmotson.crashlytics_dynamic_module
6aabb02
gJF
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
100 changes: 100 additions & 0 deletions
100
...dTest/java/com/google/firebase/crashlytics/internal/ProviderProxyNativeComponentTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| // Copyright 2021 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.firebase.crashlytics.internal; | ||
|
|
||
| import static org.mockito.ArgumentMatchers.eq; | ||
|
|
||
| import androidx.test.runner.AndroidJUnit4; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.mockito.Mock; | ||
| import org.mockito.Mockito; | ||
| import org.mockito.MockitoAnnotations; | ||
|
|
||
| @RunWith(AndroidJUnit4.class) | ||
| public class ProviderProxyNativeComponentTest { | ||
| private static final String TEST_STRING = "abc"; | ||
| private static final long TEST_LONG = 123; | ||
| private static final boolean TEST_BOOLEAN = true; | ||
| private static final int TEST_INT = 1234; | ||
|
|
||
| @Mock private CrashlyticsNativeComponent component; | ||
|
|
||
| @Before | ||
| public void setUp() throws Exception { | ||
| MockitoAnnotations.initMocks(this); | ||
| } | ||
|
|
||
| @Test | ||
| public void testProviderProxyCallsThroughProvidedValue() { | ||
| ProviderProxyNativeComponent proxy = new ProviderProxyNativeComponent(() -> component); | ||
|
|
||
| proxy.hasCrashDataForSession(TEST_STRING); | ||
| Mockito.verify(component, Mockito.times(1)).hasCrashDataForSession(eq(TEST_STRING)); | ||
|
|
||
| proxy.openSession(TEST_STRING); | ||
| Mockito.verify(component, Mockito.times(1)).openSession(eq(TEST_STRING)); | ||
|
|
||
| proxy.finalizeSession(TEST_STRING); | ||
| Mockito.verify(component, Mockito.times(1)).finalizeSession(eq(TEST_STRING)); | ||
|
|
||
| proxy.getSessionFileProvider(TEST_STRING); | ||
| Mockito.verify(component, Mockito.times(1)).getSessionFileProvider(eq(TEST_STRING)); | ||
|
|
||
| proxy.writeBeginSession(TEST_STRING, TEST_STRING, TEST_LONG); | ||
| Mockito.verify(component, Mockito.times(1)) | ||
| .writeBeginSession(eq(TEST_STRING), eq(TEST_STRING), eq(TEST_LONG)); | ||
|
|
||
| proxy.writeSessionApp( | ||
| TEST_STRING, TEST_STRING, TEST_STRING, TEST_STRING, TEST_STRING, TEST_INT, TEST_STRING); | ||
| Mockito.verify(component, Mockito.times(1)) | ||
| .writeSessionApp( | ||
| eq(TEST_STRING), | ||
| eq(TEST_STRING), | ||
| eq(TEST_STRING), | ||
| eq(TEST_STRING), | ||
| eq(TEST_STRING), | ||
| eq(TEST_INT), | ||
| eq(TEST_STRING)); | ||
|
|
||
| proxy.writeSessionOs(TEST_STRING, TEST_STRING, TEST_STRING, TEST_BOOLEAN); | ||
| Mockito.verify(component, Mockito.times(1)) | ||
| .writeSessionOs(eq(TEST_STRING), eq(TEST_STRING), eq(TEST_STRING), eq(TEST_BOOLEAN)); | ||
|
|
||
| proxy.writeSessionDevice( | ||
| TEST_STRING, | ||
| TEST_INT, | ||
| TEST_STRING, | ||
| TEST_INT, | ||
| TEST_LONG, | ||
| TEST_LONG, | ||
| TEST_BOOLEAN, | ||
| TEST_INT, | ||
| TEST_STRING, | ||
| TEST_STRING); | ||
| Mockito.verify(component, Mockito.times(1)) | ||
| .writeSessionDevice( | ||
| eq(TEST_STRING), | ||
| eq(TEST_INT), | ||
| eq(TEST_STRING), | ||
| eq(TEST_INT), | ||
| eq(TEST_LONG), | ||
| eq(TEST_LONG), | ||
| eq(TEST_BOOLEAN), | ||
| eq(TEST_INT), | ||
| eq(TEST_STRING), | ||
| eq(TEST_STRING)); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: for this simple case you can just use the more concise: