Add Dynamic loading support to fiam. #2535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change adds Analytics load detection.
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (2b59b4a0) is created by Prow via merging commits: 00e9d49 02ab187. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (2b59b4a0) is created by Prow via merging commits: 00e9d49 02ab187. |
...aging/src/main/java/com/google/firebase/inappmessaging/internal/ProxyAnalyticsConnector.java
Show resolved
Hide resolved
...aging/src/main/java/com/google/firebase/inappmessaging/internal/ProxyAnalyticsConnector.java
Show resolved
Hide resolved
| AnalyticsConnectorHandle handle = | ||
| connector.registerAnalyticsConnectorListener(s, listener); | ||
| instance = handle; | ||
| if (!eventNames.isEmpty()) { |
There was a problem hiding this comment.
Worth adding some comments here.
...aging/src/main/java/com/google/firebase/inappmessaging/internal/ProxyAnalyticsConnector.java
Outdated
Show resolved
Hide resolved
ashwinraghav
approved these changes
Mar 24, 2021
davidmotson
approved these changes
Mar 25, 2021
prakhar1989
approved these changes
Mar 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change adds Analytics load detection.