Skip to content

Add dynamic module support to Remote Config. #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2021
Merged

Add dynamic module support to Remote Config. #2547

merged 1 commit into from
Mar 30, 2021

Conversation

vkryachko
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes Override cla label Mar 25, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 25, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-config

    SDK overall coverage changed from 88.61% (0b61832) to 88.53% (921811de) by -0.08%.

    Filename Base (0b61832) Head (921811de) Diff
    ConfigFetchHandler.java 97.18% 97.20% +0.02%
    Personalization.java 90.91% 88.57% -2.34%
    RemoteConfigComponent.java 96.67% 96.61% -0.06%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (921811de) is created by Prow via merging commits: 0b61832 5e10894.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 25, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-config

    Type Base (0b61832) Head (921811de) Diff
    aar 71.6 kB 71.8 kB +259 B (+0.4%)
    apk (aggressive) 91.2 kB 91.3 kB +8 B (+0.0%)
    apk (release) 718 kB 718 kB +40 B (+0.0%)

Test Logs

Notes

Head commit (921811de) is created by Prow via merging commits: 0b61832 5e10894.

@vkryachko
Copy link
Member Author

/retest

@rlazo rlazo merged commit 8c69256 into master Mar 30, 2021
@rlazo rlazo deleted the vk.rc_provider branch March 30, 2021 02:14
@firebase firebase locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @rlazo @googlebot