Skip to content

Simplify Mutations #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

Simplify Mutations #2577

merged 1 commit into from
May 25, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Apr 9, 2021 •
edited
Loading

This brings our Mutation-parsing logic in line with that of iOS (firebase/firebase-ios-sdk#8124)

@googlebot googlebot added the cla: yes Override cla label Apr 9, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 47.23% (978bfbc) to 47.11% (aeec4a36) by -0.11%.

    Filename Base (978bfbc) Head (aeec4a36) Diff
    AsyncQueue.java 78.39% 76.88% -1.51%
    FirestoreClient.java 34.96% 30.08% -4.88%
    LocalStore.java 99.28% 99.28% -0.01%
    LruGarbageCollector.java 93.46% 84.11% -9.35%
    Mutation.java 98.15% 98.00% -0.15%
    MutationBatch.java 88.33% 88.14% -0.20%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (aeec4a36) is created by Prow via merging commits: 978bfbc b6989ca.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (978bfbc) Head (aeec4a36) Diff
    aar 1.03 MB 1.03 MB -140 B (-0.0%)
    apk (release) 3.19 MB 3.19 MB -184 B (-0.0%)

Test Logs

Notes

Head commit (aeec4a36) is created by Prow via merging commits: 978bfbc b6989ca.

@schmidt-sebastian schmidt-sebastian merged commit b5d06cd into master May 25, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/simplify branch May 25, 2021 15:13
@firebase firebase locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

@thebrianchen thebrianchen Awaiting requested review from thebrianchen

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @google-oss-bot @dconeybe @googlebot