Skip to content

Add firebase-common macrobenchmark. #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2021
Merged

Add firebase-common macrobenchmark. #2676

merged 2 commits into from
May 20, 2021

Conversation

vkryachko
Copy link
Member

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label May 19, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 19, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.01% (5a0ed84) to 50.00% (e40567eb) by -0.01%.

    Filename Base (5a0ed84) Head (e40567eb) Diff
    ViewProcessor.java 92.10% 91.79% -0.30%

  • firebase-firestore

    SDK overall coverage changed from 47.23% (5a0ed84) to 47.14% (e40567eb) by -0.09%.

    Filename Base (5a0ed84) Head (e40567eb) Diff
    AsyncQueue.java 78.39% 77.89% -0.50%
    FirestoreClient.java 34.96% 30.08% -4.88%
    LruGarbageCollector.java 93.46% 84.11% -9.35%

  • firebase-storage

    SDK overall coverage changed from 85.85% (5a0ed84) to 85.81% (e40567eb) by -0.04%.

    Filename Base (5a0ed84) Head (e40567eb) Diff
    StreamDownloadTask.java 88.89% 88.41% -0.48%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (e40567eb) is created by Prow via merging commits: 5a0ed84 e9beefe.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 19, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (5a0ed84) and head commit (e40567eb).

Test Logs

Notes

Head commit (e40567eb) is created by Prow via merging commits: 5a0ed84 e9beefe.

@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed e9beefe link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko requested a review from yifanyang May 20, 2021 18:26
yifanyang
yifanyang approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@yifanyang yifanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll get the application-id part removed in a follow-up PR.

@vkryachko vkryachko merged commit cbefe28 into master May 20, 2021
@vkryachko vkryachko deleted the vk.common_test branch May 20, 2021 18:31
@firebase firebase locked and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yifanyang yifanyang yifanyang approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkryachko @google-oss-bot @yifanyang