Skip to content

Add support for ktx dependencies in the recipe generator. #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2021

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented May 20, 2021

No description provided.

@rlazo rlazo requested a review from davidmotson May 20, 2021 05:41
@googlebot googlebot added the cla: yes Override cla label May 20, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.01% (5a0ed84) to 50.05% (43a7f611) by +0.04%.

    Filename Base (5a0ed84) Head (43a7f611) Diff
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (43a7f611) is created by Prow via merging commits: 5a0ed84 177a24c.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (5a0ed84) and head commit (43a7f611).

Test Logs

Notes

Head commit (43a7f611) is created by Prow via merging commits: 5a0ed84 177a24c.

@rlazo
Copy link
Collaborator Author

rlazo commented May 21, 2021

/test check-changed

2 similar comments
@rlazo
Copy link
Collaborator Author

rlazo commented May 22, 2021

/test check-changed

@rlazo
Copy link
Collaborator Author

rlazo commented May 22, 2021

/test check-changed

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 22, 2021

@rlazo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 177a24c link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo
Copy link
Collaborator Author

rlazo commented May 22, 2021

/test check-changed

@rlazo rlazo merged commit ff8f905 into master May 22, 2021
@rlazo rlazo deleted the rl.bomgeneraup928 branch May 22, 2021 15:56
@firebase firebase locked and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants