Fix incremental builds for firebase-crashlytics-ndk #2692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One task was incorrectly relying on `externalNativeBuildClean`, which caused all native files to be rebuilt on every build, regardless of if they were changed. That task dependency has been removed, reducing incremental build times from 6m to ~13s.
Binary Size ReportAffected SDKsNo changes between base commit (b5d06cd) and head commit (04d746df). Test Logs
NotesHead commit (04d746df) is created by Prow via merging commits: b5d06cd 7d64e56. |
kmandrika
approved these changes
May 25, 2021
Macrobenchmark ReportAffected SDKsMeasurements are for head commit (7d64e56). Diffing against base commit (b5d06cd) is working in progress.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One task was incorrectly relying on
externalNativeBuildClean,which caused all native files to be rebuilt on every build,
regardless of if they were changed. That task dependency has
been removed, reducing incremental build times from 6m to ~13s.