Skip backoff when App enters Foreground #2693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/lifecyclehooks
branch
from
7ec8cec to
dca9259
Compare
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (fe634292) is created by Prow via merging commits: b5d06cd dca9259. |
Macrobenchmark ReportAffected SDKsMeasurements are for head commit (dca9259). Diffing against base commit (b5d06cd) is working in progress.
|
var-const
approved these changes
May 26, 2021
| @Override | ||
| public void onBackgroundStateChanged(boolean background) { | ||
| if (!background && isConnected()) { | ||
| raiseCallbacks(/* connected= */ true); |
There was a problem hiding this comment.
Is invoking the callbacks enough to reset the backoff? (I presume it is, just checking)
There was a problem hiding this comment.
Yeah, they already call inhibitBackoff.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might lose network connectivity when a Firestore app is backgrounded. This PR changes our network monitor to skip the backoff when an app goes back in the foreground, which causes the SDK to immediately try to reconnect.
Tested manually.
Fixes #2637