Skip to content

Revert "Crashlytics Add Internal Keys feature for Unity Metadata" #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021

Conversation

samedson
Copy link
Contributor

Reverts #2671

We found this doesn't play nicely with the backend rollout.

@google-cla google-cla bot added the cla: yes Override cla label May 26, 2021
@samedson samedson requested a review from mrichards May 26, 2021 19:39
@samedson samedson requested a review from davidmotson May 26, 2021 19:39
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (3145da7) Head (fe398cb5) Diff
    aar 320 kB 318 kB -1.97 kB (-0.6%)
    apk (aggressive) 193 kB 193 kB -300 B (-0.2%)
    apk (release) 821 kB 821 kB -840 B (-0.1%)

Test Logs

Notes

Head commit (fe398cb5) is created by Prow via merging commits: 3145da7 b02cc4f.

@samedson samedson requested a review from rlazo May 26, 2021 19:54
Copy link
Contributor

@mrichards mrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(
We'll get it in for the next one.

@samedson samedson merged commit ae35781 into master May 26, 2021
@samedson samedson deleted the revert-2671-internal-keys branch May 26, 2021 19:55
@google-oss-bot
Copy link
Contributor

Macrobenchmark Report

Affected SDKs

Measurements are for head commit (b02cc4f). Diffing against base commit (3145da7) is working in progress.

  • baseline

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait123.0 ms171.0 ms148.5 ms158.0 ms168.5 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms69.0 ms47.5 ms67.0 ms68.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait64.0 ms91.0 ms79.5 ms85.2 ms90.2 ms
  • firebase-common

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait129.0 ms160.0 ms139.0 ms150.1 ms158.3 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms66.0 ms49.5 ms58.4 ms65.2 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait55.0 ms81.0 ms73.0 ms80.1 ms81.0 ms
  • firebase-config

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait133.0 ms189.0 ms146.5 ms167.8 ms186.3 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait43.0 ms71.0 ms53.5 ms65.1 ms70.0 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait61.0 ms94.0 ms73.0 ms83.2 ms92.3 ms
  • firebase-crashlytics

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait138.0 ms168.0 ms155.0 ms160.5 ms167.4 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms62.0 ms48.5 ms56.3 ms61.4 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait56.0 ms83.0 ms66.5 ms82.0 ms82.8 ms
  • firebase-database

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait120.0 ms170.0 ms138.0 ms159.9 ms169.6 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms64.0 ms48.5 ms61.2 ms63.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait54.0 ms94.0 ms73.0 ms88.2 ms93.2 ms
  • firebase-dynamic-links

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait125.0 ms164.0 ms141.5 ms151.1 ms161.7 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait35.0 ms70.0 ms49.5 ms64.2 ms69.2 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait53.0 ms91.0 ms68.0 ms85.2 ms90.2 ms
  • firebase-firestore

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait126.0 ms175.0 ms144.5 ms152.5 ms171.6 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms72.0 ms56.0 ms61.5 ms70.9 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait60.0 ms88.0 ms70.0 ms85.2 ms87.8 ms
  • firebase-functions

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait128.0 ms155.0 ms144.5 ms153.0 ms154.6 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait32.0 ms63.0 ms47.5 ms60.2 ms62.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait46.0 ms85.0 ms70.0 ms78.6 ms84.8 ms
  • firebase-inappmessaging-display

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait162.0 ms210.0 ms180.5 ms198.2 ms208.1 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait40.0 ms66.0 ms54.5 ms60.3 ms65.4 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait66.0 ms100.0 ms78.0 ms95.3 ms99.6 ms
  • firebase-messaging

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait138.0 ms178.0 ms154.0 ms172.0 ms176.9 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms65.0 ms48.0 ms59.1 ms64.1 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait64.0 ms101.0 ms78.0 ms86.1 ms98.3 ms
  • firebase-perf

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait141.0 ms173.0 ms154.0 ms167.0 ms171.9 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait43.0 ms67.0 ms54.5 ms63.2 ms66.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait54.0 ms102.0 ms75.0 ms88.2 ms99.7 ms
  • firebase-storage

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait124.0 ms162.0 ms142.0 ms158.3 ms161.8 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait43.0 ms65.0 ms50.0 ms59.0 ms63.9 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait60.0 ms102.0 ms74.5 ms92.1 ms100.3 ms

@firebase firebase locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants