Skip to content

Crashlytics Add Internal Keys feature for Unity Metadata (Re-Add) #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

samedson
Copy link
Contributor

@samedson samedson commented Jun 2, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Jun 2, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-crashlytics

    SDK overall coverage did not change between base commit (257f96b) and head commit (e058c554). However there are changes in individual files.

    Filename Base (257f96b) Head (e058c554) Diff
    KeysMap.java ? 0.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (e058c554) is created by Prow via merging commits: 257f96b 7cdb3b8.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (257f96b) Head (e058c554) Diff
    aar 318 kB 320 kB +1.97 kB (+0.6%)
    apk (aggressive) 193 kB 194 kB +276 B (+0.1%)
    apk (release) 821 kB 822 kB +780 B (+0.1%)

Test Logs

Notes

Head commit (e058c554) is created by Prow via merging commits: 257f96b 7cdb3b8.

@google-oss-bot
Copy link
Contributor

Macrobenchmark Report

Affected SDKs

Measurements are for head commit (7cdb3b8). Diffing against base commit (257f96b) is working in progress.

  • baseline

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait125.0 ms163.0 ms140.5 ms146.9 ms161.5 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms63.0 ms55.0 ms61.0 ms62.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait56.0 ms94.0 ms71.5 ms82.4 ms92.5 ms
  • firebase-common

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait130.0 ms172.0 ms140.0 ms159.6 ms170.7 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait32.0 ms64.0 ms51.0 ms60.0 ms63.2 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait53.0 ms88.0 ms73.0 ms86.1 ms87.8 ms
  • firebase-config

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait130.0 ms161.0 ms145.0 ms157.3 ms160.8 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait45.0 ms72.0 ms53.5 ms60.2 ms70.1 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait56.0 ms91.0 ms73.5 ms85.1 ms90.0 ms
  • firebase-crashlytics

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait134.0 ms177.0 ms156.0 ms167.3 ms175.7 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait46.0 ms83.0 ms54.0 ms68.5 ms81.1 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait52.0 ms85.0 ms74.5 ms84.1 ms85.0 ms
  • firebase-database

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait126.0 ms148.0 ms140.0 ms146.0 ms147.6 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms59.0 ms45.5 ms55.3 ms58.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait48.0 ms87.0 ms77.0 ms84.1 ms86.6 ms
  • firebase-dynamic-links

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait126.0 ms170.0 ms148.5 ms156.1 ms167.5 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait40.0 ms64.0 ms55.0 ms62.0 ms63.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait55.0 ms97.0 ms78.0 ms82.2 ms94.5 ms
  • firebase-firestore

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait126.0 ms175.0 ms147.0 ms162.4 ms173.3 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait32.0 ms64.0 ms51.0 ms59.4 ms63.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait56.0 ms94.0 ms67.5 ms84.0 ms92.1 ms
  • firebase-functions

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait123.0 ms156.0 ms142.5 ms154.1 ms155.8 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms73.0 ms52.5 ms59.5 ms71.3 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait58.0 ms96.0 ms74.0 ms87.7 ms95.6 ms
  • firebase-inappmessaging-display

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait161.0 ms201.0 ms175.5 ms189.3 ms199.3 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait39.0 ms78.0 ms53.5 ms67.2 ms76.3 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait51.0 ms90.0 ms78.0 ms83.1 ms88.9 ms
  • firebase-messaging

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait125.0 ms258.0 ms152.0 ms177.9 ms244.3 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms74.0 ms54.0 ms62.4 ms72.5 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait52.0 ms96.0 ms75.5 ms83.1 ms95.4 ms
  • firebase-perf

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait144.0 ms175.0 ms158.0 ms168.3 ms174.2 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait34.0 ms65.0 ms52.0 ms61.3 ms64.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait56.0 ms112.0 ms75.0 ms86.3 ms107.6 ms
  • firebase-storage

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait126.0 ms151.0 ms139.0 ms146.1 ms150.2 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms70.0 ms49.5 ms65.1 ms69.2 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait60.0 ms96.0 ms67.5 ms81.8 ms94.7 ms

Copy link
Contributor

@mrichards mrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@samedson samedson merged commit c816404 into master Jun 15, 2021
@samedson samedson deleted the internal-keys branch June 15, 2021 17:23
@firebase firebase locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants