Fix inaccurate activity screen metrics. #2736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (b057f165) is created by Prow via merging commits: 011b65b 8af227e. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (b057f165) is created by Prow via merging commits: 011b65b 8af227e. |
rlazo
reviewed
Jun 16, 2021
firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateMonitor.java
Show resolved
Hide resolved
|
/test check-changed |
rlazo
approved these changes
Jun 16, 2021
|
/test macrobenchmark |
visumickey
reviewed
Jun 24, 2021
firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateMonitor.java
Show resolved
Hide resolved
Macrobenchmark ReportAffected SDKsMeasurements are for head commit (5e9b2bf). Diffing against base commit (91681dd) is working in progress.
|
|
/test macrobenchmark |
|
@jeremyjiang-dev: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix:
Summary of changes:
frameMetricsAggregator.remove(activity)withframeMetricsAggregator.reset()becauseremovedoes not clean the frame metrics, causes frame metrics for each activity is added on top of the data for all previous pages.frameMetricsAggregator.remove(activity)(see b/133827763). However, this check will return false even if hardware acceleration is turned on by default. Now, if an activity is not hardware accelerated, the metrics will just be 0.