Skip to content

Upgrade gJF and remove global config for gJF. #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Upgrade gJF and remove global config for gJF. #2745

merged 1 commit into from
Jun 18, 2021

Conversation

vkryachko
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jun 17, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 17, 2021

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.05% (debdb13) to 50.01% (999f8290) by -0.04%.

    Filename Base (debdb13) Head (999f8290) Diff
    ChildChangeAccumulator.java 96.67% 83.33% -13.33%
    QueryParams.java 89.76% 90.36% +0.60%
    ViewProcessor.java 92.10% 91.79% -0.30%
  • firebase-firestore

    SDK overall coverage changed from 47.15% (debdb13) to 47.23% (999f8290) by +0.09%.

    Filename Base (debdb13) Head (999f8290) Diff
    AsyncQueue.java 77.89% 78.39% +0.50%
    FirestoreClient.java 30.08% 34.96% +4.88%
    LruGarbageCollector.java 84.11% 93.46% +9.35%
  • firebase-storage

    SDK overall coverage changed from 85.85% (debdb13) to 85.81% (999f8290) by -0.04%.

    Filename Base (debdb13) Head (999f8290) Diff
    StreamDownloadTask.java 88.89% 88.41% -0.48%
  • transport-backend-cct

    SDK overall coverage changed from 78.46% (debdb13) to 78.44% (999f8290) by -0.03%.

    Filename Base (debdb13) Head (999f8290) Diff
    CctTransportBackend.java 93.72% 93.69% -0.03%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (999f8290) is created by Prow via merging commits: debdb13 74c69c2.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 17, 2021

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (debdb13) Head (999f8290) Diff
    aar 320 kB 320 kB -3 B (-0.0%)
    apk (release) 822 kB 822 kB -24 B (-0.0%)
  • firebase-crashlytics-ktx

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 1.30 MB 1.30 MB +44 B (+0.0%)
  • firebase-datatransport

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 705 kB 705 kB -36 B (-0.0%)
  • firebase-inappmessaging

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 3.32 MB 3.32 MB +120 B (+0.0%)
  • firebase-inappmessaging-display

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 4.56 MB 4.56 MB -24 B (-0.0%)
  • firebase-inappmessaging-display-ktx

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 5.05 MB 5.05 MB +180 B (+0.0%)
  • firebase-inappmessaging-ktx

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 3.80 MB 3.80 MB -76 B (-0.0%)
  • firebase-messaging-directboot

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 2.33 MB 2.33 MB -32 B (-0.0%)
  • firebase-messaging-ktx

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 2.92 MB 2.92 MB -100 B (-0.0%)
  • firebase-ml-modeldownloader

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 791 kB 791 kB +8 B (+0.0%)
  • firebase-ml-modeldownloader-ktx

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 1.27 MB 1.27 MB +8 B (+0.0%)
  • firebase-perf

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 2.43 MB 2.43 MB +40 B (+0.0%)
  • firebase-perf-ktx

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 2.92 MB 2.92 MB +76 B (+0.0%)
  • transport-backend-cct

    Type Base (debdb13) Head (999f8290) Diff
    apk (release) 88.0 kB 88.0 kB +4 B (+0.0%)

Test Logs

Notes

Head commit (999f8290) is created by Prow via merging commits: debdb13 74c69c2.

@vkryachko vkryachko merged commit c7d8a80 into master Jun 18, 2021
@vkryachko vkryachko deleted the vk.gJF branch June 18, 2021 18:35
@google-oss-bot
Copy link
Contributor

@vkryachko: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 74c69c2 link /test check-changed
macrobenchmark 74c69c2 link /test macrobenchmark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants