Skip to content

Disable jetifier. #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2021
Merged

Disable jetifier. #2748

merged 2 commits into from
Jun 18, 2021

Conversation

vkryachko
Copy link
Member

Jetifier is no longer needed and is causing failures for the encoders
proto plugin.

@vkryachko
Disable jetifier.
ec31742 
Jetifier is no longer needed and is causing failures for the encoders
proto plugin.
@google-cla google-cla bot added the cla: yes Override cla label Jun 18, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 18, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.00% (c816404) to 49.98% (b3e4c234) by -0.02%.

    Filename Base (c816404) Head (b3e4c234) Diff
    DoubleNode.java 100.00% 88.24% -11.76%

  • firebase-firestore

    SDK overall coverage changed from 47.23% (c816404) to 47.15% (b3e4c234) by -0.09%.

    Filename Base (c816404) Head (b3e4c234) Diff
    AsyncQueue.java 78.39% 77.89% -0.50%
    FirestoreClient.java 34.96% 30.08% -4.88%
    LruGarbageCollector.java 93.46% 84.11% -9.35%

  • firebase-perf

    SDK overall coverage changed from ? (c816404) to 70.72% (b3e4c234) by ?.

    Click to show coverage changes in 97 files.
    Filename Base (c816404) Head (b3e4c234) Diff
    AddTrace.java ? 0.00% ?
    AndroidApplicationInfo.java ? 34.71% ?
    AndroidApplicationInfoOrBuilder.java ? 0.00% ?
    AndroidLogger.java ? 97.78% ?
    AndroidMemoryReading.java ? 38.36% ?
    AndroidMemoryReadingOrBuilder.java ? 0.00% ?
    AppStartTrace.java ? 85.71% ?
    AppStateMonitor.java ? 86.78% ?
    AppStateUpdateHandler.java ? 92.59% ?
    ApplicationInfo.java ? 45.00% ?
    ApplicationInfoOrBuilder.java ? 0.00% ?
    ApplicationProcessState.java ? 73.91% ?
    Clock.java ? 100.00% ?
    ConfigResolver.java ? 97.23% ?
    ConfigurationConstants.java ? 99.21% ?
    ConfigurationFlag.java ? 100.00% ?
    ConsoleUrlGenerator.java ? 62.50% ?
    Constants.java ? 95.65% ?
    Counter.java ? 90.91% ?
    CpuGaugeCollector.java ? 93.10% ?
    CpuMetricReading.java ? 39.33% ?
    CpuMetricReadingOrBuilder.java ? 0.00% ?
    DaggerFirebasePerformanceComponent.java ? 100.00% ?
    DeviceCacheManager.java ? 76.03% ?
    FirebasePerfApplicationInfoValidator.java ? 92.86% ?
    FirebasePerfGaugeMetricValidator.java ? 100.00% ?
    FirebasePerfHttpClient.java ? 93.85% ?
    FirebasePerfMetricProto.java ? 0.00% ?
    FirebasePerfNetworkValidator.java ? 86.67% ?
    FirebasePerfOkHttpClient.java ? 44.90% ?
    FirebasePerfProvider.java ? 76.92% ?
    FirebasePerfRegistrar.java ? 100.00% ?
    FirebasePerfTraceValidator.java ? 88.24% ?
    FirebasePerfUrlConnection.java ? 44.26% ?
    FirebasePerformance.java ? 83.87% ?
    FirebasePerformanceAttributable.java ? 0.00% ?
    FirebasePerformanceComponent.java ? 0.00% ?
    FirebasePerformanceInitializer.java ? 33.33% ?
    FirebasePerformanceModule.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesGaugeManagerFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java ? 100.00% ?
    FirebasePerformance_Factory.java ? 100.00% ?
    FlgTransport.java ? 83.33% ?
    GaugeManager.java ? 98.39% ?
    GaugeMetadata.java ? 32.21% ?
    GaugeMetadataManager.java ? 84.21% ?
    GaugeMetadataOrBuilder.java ? 0.00% ?
    GaugeMetric.java ? 39.47% ?
    GaugeMetricOrBuilder.java ? 0.00% ?
    HttpMetric.java ? 91.78% ?
    ImmutableBundle.java ? 100.00% ?
    InstrHttpInputStream.java ? 92.86% ?
    InstrHttpOutputStream.java ? 98.00% ?
    InstrHttpURLConnection.java ? 93.42% ?
    InstrHttpsURLConnection.java ? 94.32% ?
    InstrURLConnectionBase.java ? 95.24% ?
    InstrumentApacheHttpResponseHandler.java ? 100.00% ?
    InstrumentOkHttpEnqueueCallback.java ? 100.00% ?
    LogWrapper.java ? 23.08% ?
    MemoryGaugeCollector.java ? 90.00% ?
    NetworkConnectionInfo.java ? 0.00% ?
    NetworkConnectionInfoOrBuilder.java ? 0.00% ?
    NetworkRequestMetric.java ? 49.16% ?
    NetworkRequestMetricBuilder.java ? 95.97% ?
    NetworkRequestMetricBuilderUtil.java ? 75.00% ?
    NetworkRequestMetricOrBuilder.java ? 0.00% ?
    Optional.java ? 86.67% ?
    PendingPerfEvent.java ? 100.00% ?
    PerfMetric.java ? 33.67% ?
    PerfMetricOrBuilder.java ? 0.00% ?
    PerfMetricValidator.java ? 90.32% ?
    PerfSession.java ? 93.33% ?
    PerfSessionOrBuilder.java ? 0.00% ?
    Rate.java ? 100.00% ?
    RateLimiter.java ? 90.60% ?
    RemoteConfigManager.java ? 92.24% ?
    ResourceType.java ? 0.00% ?
    SessionAwareObject.java ? 0.00% ?
    SessionManager.java ? 100.00% ?
    SessionVerbosity.java ? 68.42% ?
    StorageUnit.java ? 57.89% ?
    Timer.java ? 93.75% ?
    Trace.java ? 96.69% ?
    TraceMetric.java ? 43.42% ?
    TraceMetricBuilder.java ? 100.00% ?
    TraceMetricOrBuilder.java ? 0.00% ?
    TransportInfo.java ? 0.00% ?
    TransportInfoOrBuilder.java ? 0.00% ?
    TransportManager.java ? 93.93% ?
    URLAllowlist.java ? 94.44% ?
    URLWrapper.java ? 0.00% ?
    Utils.java ? 78.57% ?

  • firebase-storage

    SDK overall coverage changed from 85.85% (c816404) to 85.98% (b3e4c234) by +0.13%.

    Filename Base (c816404) Head (b3e4c234) Diff
    StorageTask.java 84.29% 84.59% +0.30%
    UploadTask.java 80.58% 81.29% +0.72%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (b3e4c234) is created by Prow via merging commits: c816404 9650f0c.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 18, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (c816404) and head commit (b3e4c234).

Test Logs

Notes

Head commit (b3e4c234) is created by Prow via merging commits: c816404 9650f0c.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 18, 2021 •
edited
Loading

Macrobenchmark Report

Affected SDKs

Measurements are for head commit (9650f0c). Diffing against base commit (c816404) is working in progress.

  • baseline

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait122.0 ms172.0 ms145.0 ms159.8 ms171.0 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms65.0 ms49.0 ms59.4 ms64.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait55.0 ms85.0 ms76.5 ms80.1 ms84.2 ms

  • firebase-common

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait131.0 ms155.0 ms141.0 ms151.1 ms154.4 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms70.0 ms50.5 ms62.5 ms69.4 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait55.0 ms91.0 ms65.0 ms81.3 ms89.7 ms

  • firebase-config

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait121.0 ms166.0 ms141.0 ms150.5 ms163.9 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms65.0 ms56.0 ms61.1 ms64.4 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait50.0 ms84.0 ms74.0 ms78.2 ms83.2 ms

  • firebase-crashlytics

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait135.0 ms171.0 ms152.0 ms161.6 ms170.2 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait42.0 ms63.0 ms53.0 ms61.0 ms62.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait66.0 ms96.0 ms77.5 ms95.0 ms95.8 ms

  • firebase-database

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait128.0 ms150.0 ms142.0 ms147.2 ms149.8 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait38.0 ms59.0 ms51.5 ms56.0 ms58.4 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait52.0 ms99.0 ms73.0 ms88.8 ms98.4 ms

  • firebase-dynamic-links

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait122.0 ms167.0 ms140.0 ms155.1 ms166.6 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait40.0 ms72.0 ms53.0 ms61.6 ms71.1 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait53.0 ms91.0 ms74.0 ms88.0 ms90.4 ms

  • firebase-firestore

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait131.0 ms178.0 ms146.0 ms161.1 ms175.0 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms68.0 ms52.0 ms58.3 ms66.7 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait48.0 ms92.0 ms73.5 ms84.1 ms90.7 ms

  • firebase-functions

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait120.0 ms163.0 ms143.5 ms155.0 ms161.5 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait28.0 ms64.0 ms50.0 ms55.1 ms62.5 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait55.0 ms92.0 ms70.0 ms89.0 ms91.4 ms

  • firebase-inappmessaging-display

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait158.0 ms197.0 ms180.5 ms188.5 ms196.2 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait43.0 ms63.0 ms54.0 ms62.1 ms63.0 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait63.0 ms103.0 ms76.5 ms88.6 ms101.3 ms

  • firebase-messaging

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait134.0 ms173.0 ms146.5 ms158.1 ms170.3 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait40.0 ms67.0 ms50.5 ms59.0 ms65.5 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait55.0 ms95.0 ms79.0 ms87.6 ms94.6 ms

  • firebase-perf

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait138.0 ms197.0 ms152.0 ms169.1 ms191.9 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait41.0 ms75.0 ms48.5 ms59.1 ms72.1 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait51.0 ms90.0 ms73.0 ms82.1 ms88.7 ms

  • firebase-storage

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait132.0 ms170.0 ms147.0 ms164.1 ms169.1 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms69.0 ms48.5 ms60.3 ms67.9 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait58.0 ms93.0 ms77.0 ms83.2 ms91.5 ms

@vkryachko
Copy link
Member Author

/retest

@vkryachko vkryachko requested review from rlazo and VinayGuthal June 18, 2021 17:16
@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 9650f0c link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko merged commit debdb13 into master Jun 18, 2021
@vkryachko vkryachko deleted the vk.no_jetifier branch June 18, 2021 18:19
@firebase firebase locked and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@VinayGuthal VinayGuthal Awaiting requested review from VinayGuthal

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkryachko @google-oss-bot @rlazo