Skip to content

Upgrade kotlin dsl plugin #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Upgrade kotlin dsl plugin #2772

merged 1 commit into from
Jun 29, 2021

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jun 29, 2021

Gradle 5.6.4 expects the plugin to be version 1.2.9.

Gradle 5.6.4 expects the plugin to be version 1.2.9.
@rlazo rlazo requested a review from vkryachko June 29, 2021 05:06
@googlebot googlebot added the cla: yes Override cla label Jun 29, 2021
@rlazo rlazo requested a review from VinayGuthal June 29, 2021 05:07
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 49.98% (ecb876d) to 50.05% (bbbc52d9) by +0.08%.

    Filename Base (ecb876d) Head (bbbc52d9) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%
    DoubleNode.java 88.24% 100.00% +11.76%
  • firebase-firestore

    SDK overall coverage changed from 47.10% (ecb876d) to 47.18% (bbbc52d9) by +0.09%.

    Filename Base (ecb876d) Head (bbbc52d9) Diff
    AsyncQueue.java 77.89% 78.39% +0.50%
    FirestoreClient.java 30.08% 34.96% +4.88%
    LruGarbageCollector.java 84.11% 93.46% +9.35%
  • firebase-messaging

    SDK overall coverage changed from ? (ecb876d) to 83.43% (bbbc52d9) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (ecb876d) Head (bbbc52d9) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 65.00% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 94.79% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 63.93% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 95.48% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 89.66% ?
    TopicsSyncTask.java ? 53.33% ?
  • firebase-perf

    SDK overall coverage changed from 70.71% (ecb876d) to 70.75% (bbbc52d9) by +0.03%.

    Filename Base (ecb876d) Head (bbbc52d9) Diff
    TransportManager.java 93.93% 94.86% +0.93%
  • firebase-storage

    SDK overall coverage changed from 85.81% (ecb876d) to 85.94% (bbbc52d9) by +0.13%.

    Filename Base (ecb876d) Head (bbbc52d9) Diff
    StreamDownloadTask.java 88.41% 88.89% +0.48%
    UploadTask.java 80.58% 81.29% +0.72%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (bbbc52d9) is created by Prow via merging commits: ecb876d 8a7f1a6.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (ecb876d) and head commit (bbbc52d9).

Test Logs

Notes

Head commit (bbbc52d9) is created by Prow via merging commits: ecb876d 8a7f1a6.

@rlazo
Copy link
Collaborator Author

rlazo commented Jun 29, 2021

/test check-changed

2 similar comments
@rlazo
Copy link
Collaborator Author

rlazo commented Jun 29, 2021

/test check-changed

@rlazo
Copy link
Collaborator Author

rlazo commented Jun 29, 2021

/test check-changed

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 29, 2021

@rlazo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 8a7f1a6 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo
Copy link
Collaborator Author

rlazo commented Jun 29, 2021

/test check-changed

@rlazo rlazo merged commit 202af1d into master Jun 29, 2021
@rlazo rlazo deleted the rl.kotlinplugin2191 branch June 29, 2021 17:16
@firebase firebase locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants