Skip to content

Update alternative-root-project to remove java formatting. #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jun 29, 2021

No description provided.

@rlazo rlazo requested review from vkryachko and davidmotson June 29, 2021 20:13
@googlebot googlebot added the cla: yes Override cla label Jun 29, 2021
@google-cla google-cla bot added the cla: yes Override cla label Jun 29, 2021
}
}
}

apply plugin: MultiProjectReleasePlugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try to just apply this plugin to the main build file? it looks like it's the only difference from build.gradle

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 29, 2021

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.03% (202af1d) to 50.02% (66562f0f) by -0.01%.

    Filename Base (202af1d) Head (66562f0f) Diff
    ChildChangeAccumulator.java 96.67% 83.33% -13.33%
    DefaultPersistenceManager.java 74.76% 75.73% +0.97%
    DoubleNode.java 88.24% 100.00% +11.76%
    ViewProcessor.java 92.10% 91.79% -0.30%
    WriteTree.java 76.67% 77.22% +0.56%
  • firebase-firestore

    SDK overall coverage changed from 47.18% (202af1d) to 47.10% (66562f0f) by -0.09%.

    Filename Base (202af1d) Head (66562f0f) Diff
    AsyncQueue.java 78.39% 77.89% -0.50%
    FirestoreClient.java 34.96% 30.08% -4.88%
    LruGarbageCollector.java 93.46% 84.11% -9.35%
  • firebase-storage

    SDK overall coverage changed from ? (202af1d) to 85.85% (66562f0f) by ?.

    Click to show coverage changes in 46 files.
    Filename Base (202af1d) Head (66562f0f) Diff
    ActivityLifecycleListener.java ? 74.14% ?
    AdaptiveStreamBuffer.java ? 84.62% ?
    CancelException.java ? 100.00% ?
    CancellableTask.java ? 100.00% ?
    ControllableTask.java ? 100.00% ?
    DeleteNetworkRequest.java ? 100.00% ?
    DeleteStorageTask.java ? 100.00% ?
    ExponentialBackoffSender.java ? 86.00% ?
    FileDownloadTask.java ? 80.00% ?
    FirebaseStorage.java ? 85.11% ?
    FirebaseStorageComponent.java ? 100.00% ?
    GetDownloadUrlTask.java ? 96.77% ?
    GetMetadataNetworkRequest.java ? 100.00% ?
    GetMetadataTask.java ? 85.19% ?
    GetNetworkRequest.java ? 100.00% ?
    HttpURLConnectionFactory.java ? 0.00% ?
    HttpURLConnectionFactoryImpl.java ? 50.00% ?
    ListNetworkRequest.java ? 100.00% ?
    ListResult.java ? 100.00% ?
    ListTask.java ? 85.71% ?
    NetworkRequest.java ? 86.67% ?
    OnPausedListener.java ? 0.00% ?
    OnProgressListener.java ? 0.00% ?
    ResumableNetworkRequest.java ? 100.00% ?
    ResumableUploadByteRequest.java ? 90.91% ?
    ResumableUploadCancelRequest.java ? 100.00% ?
    ResumableUploadQueryRequest.java ? 100.00% ?
    ResumableUploadStartRequest.java ? 95.24% ?
    Slashes.java ? 88.24% ?
    Sleeper.java ? 0.00% ?
    SleeperImpl.java ? 33.33% ?
    SmartHandler.java ? 87.50% ?
    StorageException.java ? 65.45% ?
    StorageMetadata.java ? 86.34% ?
    StorageReference.java ? 89.94% ?
    StorageReferenceUri.java ? 100.00% ?
    StorageRegistrar.java ? 100.00% ?
    StorageTask.java ? 84.29% ?
    StorageTaskManager.java ? 100.00% ?
    StorageTaskScheduler.java ? 100.00% ?
    StreamDownloadTask.java ? 88.89% ?
    TaskListenerImpl.java ? 100.00% ?
    UpdateMetadataNetworkRequest.java ? 100.00% ?
    UpdateMetadataTask.java ? 82.14% ?
    UploadTask.java ? 80.58% ?
    Util.java ? 73.24% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (66562f0f) is created by Prow via merging commits: 202af1d 23f7c9d.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 29, 2021

Binary Size Report

Affected SDKs

No changes between base commit (202af1d) and head commit (66562f0f).

Test Logs

Notes

Head commit (66562f0f) is created by Prow via merging commits: 202af1d 23f7c9d.

@google-oss-bot
Copy link
Contributor

@rlazo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 23f7c9d link /test device-check-changed
smoke-tests 23f7c9d link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo rlazo merged commit a1e350a into master Jun 30, 2021
@rlazo rlazo deleted the rl.jgfalternative12 branch June 30, 2021 02:13
@firebase firebase locked and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants