Skip to content

Update AppDistributionRelease and FirebaseAppDistributionException #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2021
Merged

Update AppDistributionRelease and FirebaseAppDistributionException #2782

merged 2 commits into from
Jul 7, 2021

Conversation

rachaprince
Copy link

Convert AppDistributionRelease to AutoValue and add constructors to Exception type

@google-cla google-cla bot added the cla: yes Override cla label Jul 1, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-app-distribution

    SDK overall coverage changed from 54.44% (cd4d65a) to 41.35% (7fe5fbbf) by -13.09%.

    Filename Base (cd4d65a) Head (7fe5fbbf) Diff
    AutoValue_AppDistributionRelease.java ? 0.00% ?
    FirebaseAppDistributionException.java 72.73% 53.33% -19.39%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (7fe5fbbf) is created by Prow via merging commits: cd4d65a 049a289.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-app-distribution

    Type Base (cd4d65a) Head (7fe5fbbf) Diff
    aar 33.1 kB 36.5 kB +3.39 kB (+10.2%)

Test Logs

Notes

Head commit (7fe5fbbf) is created by Prow via merging commits: cd4d65a 049a289.

@rachaprince rachaprince force-pushed the appdistribution-small-dataclass-fixes branch from 45471ee to 7962844 Compare July 1, 2021 13:20
@rachaprince rachaprince force-pushed the appdistribution-small-dataclass-fixes branch from 7962844 to b8fdc85 Compare July 7, 2021 16:10
@rachaprince
Copy link
Author

/test api-information

@rachaprince rachaprince merged commit 1ad5e3a into master Jul 7, 2021
@rachaprince rachaprince deleted the appdistribution-small-dataclass-fixes branch July 7, 2021 20:19
@firebase firebase locked and limited conversation to collaborators Aug 7, 2021
@rachaprince rachaprince self-assigned this Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pranavrajgopal pranavrajgopal pranavrajgopal approved these changes

@andrewbibiloni andrewbibiloni andrewbibiloni approved these changes

Assignees

@rachaprince rachaprince

Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rachaprince @google-oss-bot @pranavrajgopal @andrewbibiloni