Skip to content

Adds more unit tests for signin flow #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2021
Merged

Adds more unit tests for signin flow #2786

merged 1 commit into from
Jul 7, 2021

Conversation

rachaprince
Copy link

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jul 2, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-app-distribution

    SDK overall coverage changed from 53.89% (eff44b3) to 54.44% (eb3e2744) by +0.56%.

    Filename Base (eff44b3) Head (eb3e2744) Diff
    FirebaseAppDistribution.java 64.60% 65.49% +0.88%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (eb3e2744) is created by Prow via merging commits: eff44b3 1b6d87d.

andrewbibiloni
andrewbibiloni approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@andrewbibiloni andrewbibiloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (eff44b3) and head commit (eb3e2744).

Test Logs

Notes

Head commit (eb3e2744) is created by Prow via merging commits: eff44b3 1b6d87d.

@rachaprince rachaprince merged commit 57cd78a into master Jul 7, 2021
@rachaprince rachaprince deleted the fad-additional-sign-in-tests branch July 7, 2021 14:19
@firebase firebase locked and limited conversation to collaborators Aug 7, 2021
@rachaprince rachaprince self-assigned this Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewbibiloni andrewbibiloni andrewbibiloni approved these changes

@pranavrajgopal pranavrajgopal Awaiting requested review from pranavrajgopal

Assignees

@rachaprince rachaprince

Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rachaprince @google-oss-bot @andrewbibiloni @googlebot