Skip to content

Add timestamp to fireci logging headers. #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2021
Merged

Add timestamp to fireci logging headers. #2790

merged 3 commits into from
Jul 7, 2021

Conversation

yifanyang
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Jul 2, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.02% (4ec2725) to 50.07% (637eacf0) by +0.04%.

    Filename Base (4ec2725) Head (637eacf0) Diff
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%
    DefaultPersistenceManager.java 75.73% 74.76% -0.97%
    ViewProcessor.java 91.79% 92.10% +0.30%

  • firebase-firestore

    SDK overall coverage changed from 47.10% (4ec2725) to 47.18% (637eacf0) by +0.09%.

    Filename Base (4ec2725) Head (637eacf0) Diff
    AsyncQueue.java 77.89% 78.39% +0.50%
    FirestoreClient.java 30.08% 34.96% +4.88%
    LruGarbageCollector.java 84.11% 93.46% +9.35%

  • firebase-messaging

    SDK overall coverage changed from 83.43% (4ec2725) to 83.56% (637eacf0) by +0.14%.

    Filename Base (4ec2725) Head (637eacf0) Diff
    TopicsSubscriber.java 89.66% 91.38% +1.72%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (637eacf0) is created by Prow via merging commits: 4ec2725 7bd0de4.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (4ec2725) and head commit (637eacf0).

Test Logs

Notes

Head commit (637eacf0) is created by Prow via merging commits: 4ec2725 7bd0de4.

@yifanyang yifanyang force-pushed the yifany/fireci-logging branch from 9f710ae to e30823b Compare July 3, 2021 00:21
@yifanyang
Copy link
Contributor Author

/test macrobenchmark

@google-oss-bot
Copy link
Contributor

Macrobenchmark Report

Affected SDKs

Measurements are for head commit (e30823b). Diffing against base commit (2bb3364) is working in progress.

  • baseline

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait119.0 ms152.0 ms132.5 ms146.1 ms151.0 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms77.0 ms56.5 ms64.2 ms74.9 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait49.0 ms85.0 ms73.5 ms81.1 ms84.4 ms

  • firebase-common

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait125.0 ms160.0 ms143.0 ms155.0 ms159.0 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait39.0 ms65.0 ms51.5 ms61.2 ms64.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait53.0 ms97.0 ms67.0 ms83.4 ms95.1 ms

  • firebase-config

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait134.0 ms163.0 ms144.5 ms150.1 ms162.4 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms67.0 ms44.0 ms56.2 ms65.3 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait59.0 ms86.0 ms71.5 ms84.0 ms85.6 ms

  • firebase-crashlytics

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait147.0 ms177.0 ms156.0 ms175.1 ms176.8 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait32.0 ms62.0 ms53.0 ms58.2 ms61.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait48.0 ms91.0 ms76.5 ms88.2 ms90.8 ms

  • firebase-database

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait118.0 ms165.0 ms145.0 ms153.2 ms163.1 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait40.0 ms67.0 ms52.0 ms64.2 ms66.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait54.0 ms86.0 ms71.5 ms84.1 ms85.8 ms

  • firebase-dynamic-links

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait125.0 ms162.0 ms141.0 ms156.3 ms161.4 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms63.0 ms49.5 ms60.2 ms62.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait56.0 ms89.0 ms77.5 ms87.1 ms88.8 ms

  • firebase-firestore

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait129.0 ms182.0 ms146.0 ms157.7 ms178.6 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait40.0 ms79.0 ms51.5 ms59.2 ms75.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait51.0 ms92.0 ms67.5 ms81.1 ms91.8 ms

  • firebase-functions

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait128.0 ms166.0 ms150.0 ms161.3 ms165.6 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms69.0 ms48.5 ms66.1 ms68.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait51.0 ms91.0 ms66.5 ms84.1 ms89.9 ms

  • firebase-inappmessaging-display

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait170.0 ms230.0 ms183.0 ms213.0 ms228.5 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait35.0 ms69.0 ms56.5 ms62.3 ms68.2 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait60.0 ms94.0 ms78.0 ms89.5 ms94.0 ms

  • firebase-messaging

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait127.0 ms171.0 ms146.5 ms162.3 ms169.9 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait41.0 ms61.0 ms52.5 ms56.0 ms60.1 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait53.0 ms87.0 ms69.0 ms75.9 ms86.4 ms

  • firebase-perf

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait146.0 ms187.0 ms156.5 ms168.3 ms185.7 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait38.0 ms77.0 ms57.5 ms66.7 ms76.2 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait58.0 ms95.0 ms77.0 ms91.1 ms94.4 ms

  • firebase-storage

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait121.0 ms161.0 ms144.5 ms158.0 ms160.4 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait45.0 ms64.0 ms52.5 ms60.0 ms63.2 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait55.0 ms93.0 ms70.5 ms89.1 ms92.4 ms

@yifanyang yifanyang force-pushed the yifany/fireci-logging branch 2 times, most recently from 150bfce to d8fccb4 Compare July 3, 2021 02:37
@yifanyang yifanyang force-pushed the yifany/fireci-logging branch 3 times, most recently from 48308f6 to e90680d Compare July 3, 2021 07:58
@yifanyang yifanyang force-pushed the yifany/fireci-logging branch 4 times, most recently from 12b2e6c to c424745 Compare July 3, 2021 21:57
@yifanyang yifanyang force-pushed the yifany/fireci-logging branch from c424745 to 9ebdc3a Compare July 6, 2021 01:27
@yifanyang yifanyang force-pushed the yifany/fireci-logging branch 6 times, most recently from 084bfd3 to 30008b5 Compare July 6, 2021 09:17
@yifanyang yifanyang force-pushed the yifany/fireci-logging branch from 30008b5 to 752e9dc Compare July 6, 2021 10:10
@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 7bd0de4 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yifanyang yifanyang changed the title Prepend time to fireci log records. Add timestamp to fireci logging headers. Jul 7, 2021
@yifanyang yifanyang requested a review from vkryachko July 7, 2021 17:24
vkryachko
vkryachko approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@yifanyang yifanyang merged commit 5dfdf2a into master Jul 7, 2021
@yifanyang yifanyang deleted the yifany/fireci-logging branch July 7, 2021 21:31
@firebase firebase locked and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yifanyang @google-oss-bot @vkryachko