Skip to content

Temporarily disbale a smoke test case for Crashlytics. #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

yifanyang
Copy link
Contributor

No description provided.

The test case relies on visibility change for some fields which
is only available after M100 release.
@yifanyang
Copy link
Contributor Author

Commenting out a Crashlytics test case temporarily to make smoke test suite green.

The test case in question relies on the visibility change of fields core and breadcrumbSource, which will be available in 18.2.0 (to be released in M100). It is expected to fail when smoke test builds it with 18.1.0 (the gmaven latest at the moment).

The visibility change was introduced in #2737. However, the smoke test for that PR didn't expose this failure. For some reason, the test BoMs supposed to build with gmaven version 18.1.0 (release-smoke-test, release-headPiper-smoke-test) both pined firebase-crashlytics to 18.0.2-SNAPSHOT. This may indicate some issue in logic that produces all the test BoMs in firehorn runner.

@yifanyang yifanyang marked this pull request as ready for review July 15, 2021 00:32
@yifanyang yifanyang changed the title trigger ci Temporarily disbale a smoke test case for Crashlytics. Jul 15, 2021
@firebase firebase deleted a comment from google-oss-bot Jul 15, 2021
@firebase firebase deleted a comment from google-oss-bot Jul 15, 2021
@yifanyang yifanyang requested a review from vkryachko July 15, 2021 18:35
@yifanyang yifanyang merged commit 700a658 into master Jul 15, 2021
@yifanyang yifanyang deleted the yifany/trigger-ci branch July 15, 2021 20:14
@firebase firebase locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants