Skip to content

Remove FieldMask #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

This PR:

  • Removes FieldMask
  • Re-uses testing logic for verifyRoundTrip
  • Uncovers versioning issue in overlay

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 17, 2021

Coverage Report

Affected SDKs

No changes between base commit (35d1595) and head commit (8e8f3d2a).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (8e8f3d2a6) is created by Prow via merging commits: 35d1595 618d559.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 17, 2021

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (35d1595) Head (8e8f3d2a) Diff
    aar 1.19 MB 1.19 MB -713 B (-0.1%)
    apk (release) 3.24 MB 3.24 MB -184 B (-0.0%)

Test Logs

Notes

Head commit (8e8f3d2a6) is created by Prow via merging commits: 35d1595 618d559.

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 618d559 link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wu-hui wu-hui merged commit 9401155 into wuandy/SquashBasedOnSebastianDraft Sep 20, 2021
@wu-hui wu-hui deleted the wuandy/fieldmask branch September 20, 2021 13:42
@firebase firebase locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants