Skip to content

Enable deferred installation of Crashlytics NDK signal handler. #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 21, 2021
Merged

Enable deferred installation of Crashlytics NDK signal handler. #2986

merged 4 commits into from
Sep 21, 2021

Conversation

mrichards
Copy link
Contributor

Some app development platforms, including Unity, will overwrite our
NDK signal handler if it is installed too quickly upon app launch.
This change prevents our signal handler from being immediately installed,
instead waiting for FirebaseCrashlyticsNdk#installSignalHander().

@mrichards
Enable deferred installation of Crashlytics NDK signal handler.
266fc8f 
Some app development platforms, including Unity, will overwrite our
NDK signal handler if it is installed too quickly upon app launch.
This change prevents our signal handler from being immediately installed,
instead waiting for FirebaseCrashlyticsNdk#installSignalHander().
@mrichards mrichards requested a review from kmandrika September 20, 2021 20:37
@google-cla google-cla bot added the cla: yes Override cla label Sep 20, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 20, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-crashlytics

    SDK overall coverage did not change between base commit (9b67604) and head commit (c025910a). However there are changes in individual files.

    Filename Base (9b67604) Head (c025910a) Diff
    CommonUtils.java 7.55% 7.77% +0.22%
    CrashlyticsNativeComponentDeferredProxy.java 25.81% 24.24% -1.56%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (c025910a) is created by Prow via merging commits: 9b67604 13a83ea.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 20, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (9b67604) Head (c025910a) Diff
    aar 337 kB 337 kB +254 B (+0.1%)
    apk (aggressive) 207 kB 208 kB +108 B (+0.1%)
    apk (release) 845 kB 845 kB +124 B (+0.0%)

  • firebase-crashlytics-ndk

    Type Base (9b67604) Head (c025910a) Diff
    aar 1.68 MB 1.68 MB +1.15 kB (+0.1%)
    apk (release / arm64-v8a) 1.97 MB 1.98 MB +4.10 kB (+0.2%)
    apk (release / armeabi-v7a) 1.47 MB 1.47 MB +4.10 kB (+0.3%)
    apk (release / x86) 2.01 MB 2.01 MB +4.10 kB (+0.2%)
    apk (release / x86_64) 2.08 MB 2.08 MB +4.10 kB (+0.2%)

Test Logs

Notes

Head commit (c025910a) is created by Prow via merging commits: 9b67604 13a83ea.

@mrichards mrichards merged commit cf7680d into master Sep 21, 2021
@mrichards mrichards deleted the crash-ndk-unity branch September 21, 2021 23:11
@firebase firebase locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kmandrika kmandrika kmandrika approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrichards @google-oss-bot @kmandrika