Skip to content

Add headers to support Android-application restricted API keys #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

rachaprince
Copy link

API requests have to contain additional “X-Android-Package”, “X-Android-Cert” headers for Android-application restricted keys

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-app-distribution

    SDK overall coverage changed from 69.52% (0e40391) to 69.49% (478e4cdc) by -0.03%.

    Filename Base (0e40391) Head (478e4cdc) Diff
    CheckForNewReleaseClient.java 77.11% 77.38% +0.27%
    FirebaseAppDistributionTesterApiClient.java 80.60% 78.21% -2.39%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (478e4cdc) is created by Prow via merging commits: 0e40391 7b3533d.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-app-distribution

    Type Base (0e40391) Head (478e4cdc) Diff
    aar 110 kB 111 kB +538 B (+0.5%)
    apk (release) 1.54 MB 1.54 MB +196 B (+0.0%)

Test Logs

Notes

Head commit (478e4cdc) is created by Prow via merging commits: 0e40391 7b3533d.

@rachaprince rachaprince merged commit a1031c0 into master Sep 20, 2021
@rachaprince rachaprince deleted the fad-add-restricted-api-key-support branch September 20, 2021 21:56
@firebase firebase locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants