Skip to content

FAD Fixing file provider conflict #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2021
Merged

FAD Fixing file provider conflict #2991

merged 3 commits into from
Sep 21, 2021

Conversation

manny-jimenez
Copy link
Contributor

No description provided.

@manny-jimenez manny-jimenez self-assigned this Sep 21, 2021
@google-cla google-cla bot added the cla: yes Override cla label Sep 21, 2021
@googlebot googlebot added the cla: yes Override cla label Sep 21, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 21, 2021

Coverage Report

Affected SDKs

  • firebase-app-distribution

    SDK overall coverage changed from 69.49% (a1031c0) to 69.43% (25a41929) by -0.06%.

    Filename Base (a1031c0) Head (25a41929) Diff
    FirebaseAppDistributionFileProvider.java ? 0.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (25a41929) is created by Prow via merging commits: a1031c0 f6c8735.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 21, 2021

Binary Size Report

Affected SDKs

  • firebase-app-distribution

    Type Base (a1031c0) Head (25a41929) Diff
    aar 111 kB 111 kB +300 B (+0.3%)
    apk (aggressive) 739 kB 739 kB +100 B (+0.0%)
    apk (release) 1.54 MB 1.54 MB -88 B (-0.0%)

Test Logs

Notes

Head commit (25a41929) is created by Prow via merging commits: a1031c0 f6c8735.

@google-oss-bot
Copy link
Contributor

@mannyjimenez0810: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests f6c8735 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@manny-jimenez manny-jimenez merged commit 90efb98 into master Sep 21, 2021
@manny-jimenez manny-jimenez deleted the FAD_file_provider branch September 21, 2021 15:06
@firebase firebase locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants