Skip to content

Remove special handling in Mutations #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2021
Merged

Remove special handling in Mutations #2993

merged 1 commit into from
Sep 21, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

I have been thinking more about our mutation code. I don't actually think there are any user visible mutations changes if a latency-compensated delete keeps the current version and has "localMutations" set. The only changes I see are in the local store tests, but the integration tests are unchanged.

Let me know if you can think of any problems.

This would further simplify #2962

@google-cla google-cla bot added the cla: yes Override cla label Sep 21, 2021
@googlebot googlebot added the cla: yes Override cla label Sep 21, 2021
@schmidt-sebastian
Copy link
Contributor Author

cc @thebrianchen

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 43.14% (45dd9ff) to 43.12% (9437cee8) by -0.01%.

    Filename Base (45dd9ff) Head (9437cee8) Diff
    Mutation.java 98.00% 97.87% -0.13%
    SetMutation.java 86.49% 85.71% -0.77%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (9437cee8) is created by Prow via merging commits: 45dd9ff a1755d3.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (45dd9ff) Head (9437cee8) Diff
    aar 1.20 MB 1.20 MB -236 B (-0.0%)
    apk (release) 3.24 MB 3.24 MB -24 B (-0.0%)

Test Logs

Notes

Head commit (9437cee8) is created by Prow via merging commits: 45dd9ff a1755d3.

wu-hui
wu-hui approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can neither think of anything..it looks like this logic exists at the beginning of github repo, and now nobody knows the initial reason.

But if all tests are still passing, and we cannot think of anything..I think it is fine to delete it.

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Sep 21, 2021
@schmidt-sebastian
Copy link
Contributor Author

/test smoke-tests

@schmidt-sebastian schmidt-sebastian merged commit 9b67604 into master Sep 21, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/versioncleanup branch September 21, 2021 18:43
@firebase firebase locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @google-oss-bot @wu-hui @googlebot