Add logic to use the apk hash #2994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (4b739051) is created by Prow via merging commits: 9815e45 889d14e. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (4b739051) is created by Prow via merging commits: 9815e45 889d14e. |
|
/retest |
rachaprince
commented
Sep 22, 2021
| } | ||
| } | ||
|
|
||
| private AppDistributionReleaseInternal.Builder getTestNewRelease() { |
There was a problem hiding this comment.
I modified this test to use the pattern described in: https://testing.googleblog.com/2018/02/testing-on-toilet-cleanly-create-test.html
manny-jimenez
approved these changes
Sep 22, 2021
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the SDK to use the apk zip hash returned by the backend. Fall back to the map of the external code hash until we've backfilled the apk hash in our backend.
Also renames some functions and variables for clarity.