Fix IN filters

[schmidt-sebastian]

The current implementation for IN filters has a bug.

For where('foo', 'in', [1,3]) we currently run:

foo >= 1 && foo <= 1 OR foo >= 1 && foo <= 3 OR foo >= 3 && foo <= 1 OR foo >= 3 && foo <= 3

This also returns "2".

We should only run:

foo >= 1 && foo <= 1 OR foo >= 3 && foo <= 3

[schmidt-sebastian]

cc @thebrianchen

[google-oss-bot]

Coverage Report

Affected SDKs

• firebase-firestore

  SDK overall coverage changed from 43.45% (e8ac306) to 43.44% (cfc2e721) by -0.01%.

  Filename	Base (e8ac306)	Head (cfc2e721)	Diff
  AsyncQueue.java	78.00%	77.00%	-1.00%
  SQLiteIndexManager.java	96.06%	96.04%	-0.02%

Test Logs

• Base (e8ac3065): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1443263614608740356
• Head (cfc2e721): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3002/check-coverage-changed/1443265125359292424

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (cfc2e721) is created by Prow via merging commits: e8ac306 abcb01e.

[google-oss-bot]

Binary Size Report

Affected SDKs

• firebase-firestore

  Type	Base (e8ac306)	Head (cfc2e721)	Diff
  aar	1.20 MB	1.20 MB	-74 B (-0.0%)
  apk (release)	3.24 MB	3.24 MB	-72 B (-0.0%)

Test Logs

• Base (e8ac3065): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1443263614608740357
• Head (cfc2e721): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3002/binary-size/1443265125359292426

Notes

Head commit (cfc2e721) is created by Prow via merging commits: e8ac306 abcb01e.