Skip to content

Clarify the log statements so that it differentiates between sampling… #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2022
Merged

Clarify the log statements so that it differentiates between sampling… #3012

merged 1 commit into from
Feb 2, 2022

Conversation

raymondlam
Copy link
Member

… and rate limited.

  • Split up RateLimiter.check() to have separate methods for sampling and ratelimiting.
  • Updated some test variable namings to differentiate between
    RateLimiter/RateLimiterImpl.

@google-cla google-cla bot added the cla: yes Override cla label Sep 29, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 29, 2021 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (eeef364) and merge commit (cc4a749).

Test Logs

Notes

  • Commit (cc4a749) is created by Prow via merging PR base commit (eeef364) and head commit (c5b1955).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hgf4qTP3LU.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 29, 2021 •
edited
Loading

Size Report 1

Affected Products

  • firebase-perf

    TypeBase (eeef364)Merge (cc4a749)Diff
    aar301 kB301 kB+69 B (+0.0%)
    apk (aggressive)982 kB982 kB-48 B (-0.0%)
    apk (release)2.45 MB2.45 MB+72 B (+0.0%)

Test Logs

Notes

  • Commit (cc4a749) is created by Prow via merging PR base commit (eeef364) and head commit (c5b1955).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6RZh9ZQBeh.html

@raymondlam
Copy link
Member Author

/test check-changed

jeremyjiang-dev
jeremyjiang-dev approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@jeremyjiang-dev jeremyjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

visumickey
visumickey reviewed Oct 1, 2021
View reviewed changes
Copy link
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the change. I see a ton of improvements that needs to be done in the code and it is hard to navigate through that. Appreciate you taking time to swim through this code. Good work!

@raymondlam
Clarify the log statements so that it differentiates between sampling…
c5b1955 
… and rate limited.

- Split up RateLimiter.check() to have separate methods for sampling and ratelimiting.
- Updated some test variable namings to differentiate between
RateLimiter/RateLimiterImpl.
@raymondlam raymondlam force-pushed the perf_ratelimiting_logs branch from 5523791 to c5b1955 Compare January 31, 2022 23:24
@raymondlam
Copy link
Member Author

@visumickey Can you take a look at the PR again. Thanks!

@visumickey visumickey merged commit 486da83 into firebase:master Feb 2, 2022
@firebase firebase locked and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@visumickey visumickey visumickey approved these changes

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raymondlam @google-oss-bot @visumickey @jeremyjiang-dev