Don't send fatal uncaught exception if an NDK crash exists #3020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our backend expects at most one fatal event per session. In some cases, such as Unity, the native signal handler may cause an uncaught exception to be thrown, after we have recorded the NDK crash. If this happens, Crashlytics should ignore the uncaught exception and send the NDK crash information as the fatal event.
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (6fc39fe4) is created by Prow via merging commits: 1e58174 db6207d. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (6fc39fe4) is created by Prow via merging commits: 1e58174 db6207d. |
mrober
approved these changes
Oct 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our backend expects at most one fatal event per session. In some cases,
such as Unity, the native signal handler may cause an uncaught exception
to be thrown, after we have recorded the NDK crash. If this happens,
Crashlytics should ignore the uncaught exception and send the NDK
crash information as the fatal event.