Skip to content

AppCheck integration with Firestore #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

AppCheck integration with Firestore #3028

wants to merge 10 commits into from

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Oct 5, 2021

This is the same as #3027, but AppCheck token change listeners have been removed.

@google-cla google-cla bot added the cla: yes Override cla label Oct 5, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 5, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 43.55% (7a48c9d) to 43.50% (032df49f) by -0.05%.

    Filename Base (7a48c9d) Head (032df49f) Diff
    DeleteMutation.java 95.00% 90.00% -5.00%
    FirebaseAppCheckTokenProvider.java ? 16.67% ?
    FirebaseFirestore.java 37.87% 38.60% +0.73%
    FirestoreCallCredentials.java 19.23% 14.55% -4.69%
    FirestoreChannel.java 14.29% 14.91% +0.63%
    FirestoreClient.java 29.01% 29.55% +0.54%
    SetMutation.java 94.29% 97.14% +2.86%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (032df49f) is created by Prow via merging commits: 7a48c9d 3352ea0.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 5, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (7a48c9d) Head (032df49f) Diff
    aar 1.20 MB 1.21 MB +3.54 kB (+0.3%)
    apk (aggressive) 443 kB 443 kB +64 B (+0.0%)
    apk (release) 3.24 MB 3.25 MB +7.76 kB (+0.2%)

Test Logs

Notes

Head commit (032df49f) is created by Prow via merging commits: 7a48c9d 3352ea0.

@ehsannas
Copy link
Contributor Author

ehsannas commented Oct 5, 2021

/retest

@ehsannas
Copy link
Contributor Author

ehsannas commented Oct 5, 2021

@google-oss-bot /retest

@ehsannas ehsannas closed this Oct 10, 2021
@firebase firebase locked and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @schmidt-sebastian