Collect heartbeat in android #3120

VinayGuthal · 2021-11-10T10:18:36Z

No description provided.

google-oss-bot · 2021-11-10T10:29:09Z

Binary Size Report

Affected SDKs

base

Type Base (a5f2f99) Head (3547a4ff) Diff

apk (aggressive) ? 8.39 kB ? (?)

apk (release) ? 8.65 kB ? (?)
firebase-annotations

Type Base (a5f2f99) Head (3547a4ff) Diff

apk (aggressive) ? 8.39 kB ? (?)

apk (release) ? 8.83 kB ? (?)
firebase-common

Type Base (a5f2f99) Head (3547a4ff) Diff

aar ? 49.0 kB ? (?)

apk (aggressive) ? 80.7 kB ? (?)

apk (release) ? 637 kB ? (?)
firebase-components

Type Base (a5f2f99) Head (3547a4ff) Diff

aar ? 41.4 kB ? (?)

apk (aggressive) ? 8.68 kB ? (?)

apk (release) ? 29.5 kB ? (?)
firebase-datatransport

Type Base (a5f2f99) Head (3547a4ff) Diff

aar ? 4.83 kB ? (?)

apk (aggressive) ? 127 kB ? (?)

apk (release) ? 723 kB ? (?)
firebase-encoders

Type Base (a5f2f99) Head (3547a4ff) Diff

apk (aggressive) ? 8.68 kB ? (?)

apk (release) ? 15.3 kB ? (?)
firebase-encoders-json

Type Base (a5f2f99) Head (3547a4ff) Diff

aar ? 10.5 kB ? (?)

apk (aggressive) ? 8.68 kB ? (?)

apk (release) ? 20.1 kB ? (?)
firebase-encoders-proto

Type Base (a5f2f99) Head (3547a4ff) Diff

apk (aggressive) ? 8.68 kB ? (?)

apk (release) ? 21.6 kB ? (?)
firebase-installations

Type Base (a5f2f99) Head (3547a4ff) Diff

aar ? 54.6 kB ? (?)

apk (aggressive) ? 82.2 kB ? (?)

apk (release) ? 659 kB ? (?)
firebase-installations-interop

Type Base (a5f2f99) Head (3547a4ff) Diff

aar ? 8.06 kB ? (?)

apk (aggressive) ? 55.4 kB ? (?)

apk (release) ? 607 kB ? (?)
firebase-messaging

Type Base (a5f2f99) Head (3547a4ff) Diff

aar ? 221 kB ? (?)

apk (aggressive) ? 546 kB ? (?)

apk (release) ? 2.46 MB ? (?)
transport-api

Type Base (a5f2f99) Head (3547a4ff) Diff

aar ? 6.57 kB ? (?)

apk (aggressive) ? 8.68 kB ? (?)

apk (release) ? 14.9 kB ? (?)
transport-backend-cct

Type Base (a5f2f99) Head (3547a4ff) Diff

aar ? 53.5 kB ? (?)

apk (aggressive) ? 58.0 kB ? (?)

apk (release) ? 105 kB ? (?)
transport-runtime

Type Base (a5f2f99) Head (3547a4ff) Diff

aar ? 178 kB ? (?)

apk (aggressive) ? 43.8 kB ? (?)

apk (release) ? 82.6 kB ? (?)

Test Logs

Head (3547a4ff): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3120/binary-size/1463795555908980739

Notes

Head commit (3547a4ff) is created by Prow via merging commits: a5f2f99 53905fb.

google-oss-bot · 2021-11-10T10:30:32Z

Coverage Report

Affected SDKs

`firebase-common`

SDK overall coverage changed from 53.21% (a5f2f99) to 56.37% (3547a4ff) by +3.16%.

Filename	Base (`a5f2f99`)	Head (3547a4ff)	Diff
AutoValue_HeartBeatResult.java	0.00%	33.33%	+33.33%
AutoValue_SdkHeartBeatResult.java	54.55%	0.00%	-54.55%
DefaultHeartBeatController.java	?	42.86%	?
DefaultHeartBeatInfo.java	10.34%	22.58%	+12.24%
FirebaseApp.java	52.68%	54.25%	+1.56%
FirebaseCommonRegistrar.java	95.74%	95.83%	+0.09%
HeartBeatController.java	?	0.00%	?
HeartBeatInfoStorage.java	80.65%	87.80%	+7.16%
HeartBeatResult.java	0.00%	100.00%	+100.00%
SdkHeartBeatResult.java	100.00%	0.00%	-100.00%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (3547a4ff) is created by Prow via merging commits: a5f2f99 53905fb.

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/HeartBeatController.java

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatController.java

maksymmalyhin · 2021-11-10T17:00:08Z

cc @paulb777

vkryachko · 2021-11-16T21:05:05Z

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatController.java

+      String persistenceKey,
+      Set<HeartBeatConsumer> consumers,
+      Provider<UserAgentPublisher> userAgentProvider) {
+    // It is very important the executor is single threaded as otherwise it would lead to


Instead of having this hard requirement to have a single threaded executor, would it make sense to instead make critical sections synchronized(DefaultHeartBeatController.this) { /* .. */ }?

Can this comment be removed now?

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/HeartBeatInfoStorage.java

vkryachko · 2021-11-18T17:00:26Z

Looks like CI failures are legit

vkryachko · 2021-11-23T18:53:51Z

...e-common/src/test/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatControllerTest.java

+    String expected =
+        Base64.getEncoder()
+            .encodeToString(
+                "[{\"date\":[\"2015-03-02\"],\"agent\":\"test-agent\",\"version\":\"1\"},{\"date\":[\"2015-03-03\"],\"agent\":\"test-agent-1\",\"version\":\"1\"}]"


Why is the version part of every object? I think instead we wanted it to be:

{ "version": "1", "heartbeats": [] }

vkryachko · 2021-11-23T18:55:26Z

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatController.java

+      String persistenceKey,
+      Set<HeartBeatConsumer> consumers,
+      Provider<UserAgentPublisher> userAgentProvider) {
+    // It is very important the executor is single threaded as otherwise it would lead to


Can this comment be removed now?

firebase-common/src/main/java/com/google/firebase/FirebaseApp.java

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatController.java

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/HeartBeatInfoStorage.java

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatController.java

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/HeartBeatInfoStorage.java

ncooke3 · 2021-11-24T17:53:45Z

...e-common/src/test/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatControllerTest.java

+    String expected =
+        Base64.getEncoder()
+            .encodeToString(
+                "[{\"date\":[\"2015-03-02\"],\"agent\":\"test-agent\",\"version\":\"1\"},{\"date\":[\"2015-03-03\"],\"agent\":\"test-agent-1\",\"version\":\"1\"}]"


firebase-common/src/main/java/com/google/firebase/heartbeatinfo/HeartBeatController.java

...e-common/src/test/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatControllerTest.java

VinayGuthal · 2021-11-25T09:16:07Z

/test check-changed

google-oss-bot · 2021-11-25T09:36:52Z

@VinayGuthal: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
device-check-changed	`53905fb`	link	`/test device-check-changed`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

add heart beat

19d3166

google-cla bot added the cla: yes Override cla label Nov 10, 2021

google-oss-bot added the size/XL label Nov 10, 2021

VinayGuthal requested review from vkryachko and maksymmalyhin November 10, 2021 10:22

update

9d51fda

vkryachko reviewed Nov 10, 2021

View reviewed changes

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/HeartBeatController.java Outdated Show resolved Hide resolved

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/HeartBeatController.java Outdated Show resolved Hide resolved

VinayGuthal commented Nov 10, 2021

View reviewed changes

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatController.java Outdated Show resolved Hide resolved

maksymmalyhin requested a review from ncooke3 November 10, 2021 16:59

VinayGuthal added 3 commits November 16, 2021 22:09

update according to comments

cd589ed

update

db2cecf

update

116088c

vkryachko reviewed Nov 16, 2021

View reviewed changes

update comments

273b6e7

VinayGuthal requested a review from vkryachko November 17, 2021 18:33

update

dcf9e44

vkryachko reviewed Nov 23, 2021

View reviewed changes

gjf

3f93218

vkryachko reviewed Nov 24, 2021

View reviewed changes

ncooke3 reviewed Nov 24, 2021

View reviewed changes

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/HeartBeatController.java Outdated Show resolved Hide resolved

...e-common/src/test/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatControllerTest.java Outdated Show resolved Hide resolved

address comments

53905fb

VinayGuthal changed the base branch from master to platform_logging_main_branch November 25, 2021 09:03

VinayGuthal merged commit feb69dd into platform_logging_main_branch Nov 25, 2021

VinayGuthal deleted the platform_heartbeat branch November 25, 2021 09:37

firebase locked and limited conversation to collaborators Dec 26, 2021

Collect heartbeat in android #3120

Collect heartbeat in android #3120

Uh oh!

Conversation

VinayGuthal commented Nov 10, 2021

Uh oh!

google-oss-bot commented Nov 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

base

firebase-annotations

firebase-common

firebase-components

firebase-datatransport

firebase-encoders

firebase-encoders-json

firebase-encoders-proto

firebase-installations

firebase-installations-interop

firebase-messaging

transport-api

transport-backend-cct

transport-runtime

Test Logs

Notes

Uh oh!

google-oss-bot commented Nov 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Affected SDKs

firebase-common

Test Logs

Notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maksymmalyhin commented Nov 10, 2021

Uh oh!

vkryachko Nov 16, 2021

Choose a reason for hiding this comment

Uh oh!

vkryachko Nov 23, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vkryachko commented Nov 18, 2021

Uh oh!

vkryachko Nov 23, 2021

Choose a reason for hiding this comment

Uh oh!

ncooke3 Nov 24, 2021

Choose a reason for hiding this comment

Uh oh!

vkryachko Nov 23, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ncooke3 Nov 24, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

VinayGuthal commented Nov 25, 2021

Uh oh!

google-oss-bot commented Nov 25, 2021

Uh oh!

Uh oh!

google-oss-bot commented Nov 10, 2021 •

edited

Loading

`base`

`firebase-annotations`

`firebase-common`

`firebase-components`

`firebase-datatransport`

`firebase-encoders`

`firebase-encoders-json`

`firebase-encoders-proto`

`firebase-installations`

`firebase-installations-interop`

`firebase-messaging`

`transport-api`

`transport-backend-cct`

`transport-runtime`

google-oss-bot commented Nov 10, 2021 •

edited

Loading

`firebase-common`