Skip to content

Fix metrics counter reporting. #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Fix metrics counter reporting. #3128

merged 2 commits into from
Nov 11, 2021

Conversation

vkryachko
Copy link
Member

The issue was that we were never resetting counters after a successful
metrics upload. This resulted in ever increasing counter values that did
not represent reality.

The issue was that we were never resetting counters after a successful
metrics upload. This resulted in ever increasing counter values that did
not represent reality.
@google-cla google-cla bot added the cla: yes Override cla label Nov 11, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2021

Coverage Report

Affected SDKs

  • transport-runtime

    SDK overall coverage changed from 55.31% (8068a9b) to 55.40% (72128d72) by +0.09%.

    Filename Base (8068a9b) Head (72128d72) Diff
    Uploader.java 94.74% 94.95% +0.21%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (72128d72) is created by Prow via merging commits: 8068a9b 270ed12.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2021

Binary Size Report

Affected SDKs

  • transport-runtime

    Type Base (8068a9b) Head (72128d72) Diff
    aar 178 kB 178 kB +158 B (+0.1%)
    apk (aggressive) 43.5 kB 43.8 kB +216 B (+0.5%)
    apk (release) 82.4 kB 82.6 kB +140 B (+0.2%)

Test Logs

Notes

Head commit (72128d72) is created by Prow via merging commits: 8068a9b 270ed12.

@vkryachko
Copy link
Member Author

/retest

1 similar comment
@vkryachko
Copy link
Member Author

/retest

@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 270ed12 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko merged commit fe64756 into master Nov 11, 2021
@vkryachko vkryachko deleted the vk.transport_metrics_fix branch November 11, 2021 17:46
@firebase firebase locked and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants